chrome/android/javatests/src/org/chromium/chrome/browser/WebappAuthenticatorTest.java - Issue 1297073004: Fix various errorprone warnings and errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/WebappAuthenticatorTest.java

Issue 1297073004: Fix various errorprone warnings and errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove third_party/mojo/src change. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/WebappAuthenticatorTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/WebappAuthenticatorTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/WebappAuthenticatorTest.java

index 2d075f155c56701fd28d7936ed0f98eeb7ed00e1..2353fa3313159b8baa65b8ba8211c56cc04c4fc4 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/WebappAuthenticatorTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/WebappAuthenticatorTest.java

@@ -17,7 +17,7 @@ public class WebappAuthenticatorTest extends InstrumentationTestCase {

assertNotNull(mac);

assertTrue(WebappAuthenticator.isUrlValid(context, url, mac));

assertFalse(WebappAuthenticator.isUrlValid(context, url + "?goats=true", mac));

- mac[4] += 1;

+ mac[4] += (byte) 1;

assertFalse(WebappAuthenticator.isUrlValid(context, url, mac));

}