Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1296743003: Update BitField3 type in gen-postmortem-metadata.py (Closed)

Created:
5 years, 4 months ago by julien.gilli
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update BitField3 type in gen-postmortem-metadata.py Since https://codereview.chromium.org/272163002, BitField3 is a raw uint32 field, and not a SMI anymore. Update tools/gen-postmortem-metadata.py so that post-mortem tools can work with versions of V8 that shipped after that change. This change was merged in github.com/joyent/node right before node v0.12.0 was released. R=danno@chromium.org TEST=mdb_v8, a post-mortem debugging tool running on SmartOS, has been using this change since Node.js v0.12.0 was released BUG= Committed: https://crrev.com/ff7d70bf414e2441c6ac14ba69840199840220c2 Cr-Commit-Position: refs/heads/master@{#30839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gen-postmortem-metadata.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
julien.gilli
5 years, 4 months ago (2015-08-14 23:26:02 UTC) #1
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-07 04:22:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296743003/1
5 years, 3 months ago (2015-09-10 17:39:43 UTC) #5
commit-bot: I haz the power
The author julien.gilli@joyent.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 3 months ago (2015-09-10 17:39:44 UTC) #7
julien.gilli
On 2015/09/10 17:39:44, commit-bot: I haz the power wrote: > The author mailto:julien.gilli@joyent.com has not ...
5 years, 3 months ago (2015-09-10 22:03:51 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296743003/1
5 years, 3 months ago (2015-09-18 22:08:52 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 22:35:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296743003/1
5 years, 3 months ago (2015-09-18 22:39:58 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 22:41:09 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 22:41:37 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff7d70bf414e2441c6ac14ba69840199840220c2
Cr-Commit-Position: refs/heads/master@{#30839}

Powered by Google App Engine
This is Rietveld 408576698