Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 272163002: Make BitField3 a raw uint32 field, and move to the start of the map. (Closed)

Created:
6 years, 7 months ago by Toon Verwaest
Modified:
6 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Make BitField3 a raw uint32 field, and move to the start of the map. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21225

Patch Set 1 #

Patch Set 2 : Fix 64 #

Patch Set 3 : ARM #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -40 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +5 lines, -6 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 7 months ago (2014-05-09 12:16:33 UTC) #1
Benedikt Meurer
LGTM
6 years, 7 months ago (2014-05-09 12:19:13 UTC) #2
Toon Verwaest
6 years, 7 months ago (2014-05-09 13:18:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r21225 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698