Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1879)

Issue 1296723005: [CacheStorage] Use appopriate type parameters for WebCallbacks (3/3). (Closed)

Created:
5 years, 4 months ago by yhirano
Modified:
5 years, 4 months ago
Reviewers:
nhiroki
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CacheStorage] Use appopriate type parameters for WebCallbacks (3/3). This series of CLs fixes WebCallback parameter types used in CacheStorage. - WebServiceWorkerResponse* (ownership not transferred) => const WebServiceWorkerResponse& - WebVector<WebServiceWorkerResponse>* (ownership not transferred) => const WebVector<WebServiceWorkerResponse>& - WebVector<WebServiceWorkerRequest>* (ownership not transferred) => const WebVector<WebServiceWorkerRequest>& - WebServiceWorkerCache* (ownership transferred) => WebPassOwnPtr<WebServiceWorkerCache> - WebVector<WebString>* (ownership not transferred) => const WebVector<WebString>& - WebServiceWorkerCacheError* (ownership transferred) => WebServiceWorkerCacheError 1/3: https://codereview.chromium.org/1284173004/ 2/3: https://codereview.chromium.org/1284283003/ 3/3: https://codereview.chromium.org/1296723005/ BUG=493531 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200897

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -78 lines) Patch
M public/platform/modules/serviceworker/WebServiceWorkerCache.h View 1 1 chunk +3 lines, -33 lines 0 comments Download
M public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h View 1 1 chunk +4 lines, -45 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
yhirano
5 years, 4 months ago (2015-08-19 10:27:26 UTC) #2
nhiroki
lgtm
5 years, 4 months ago (2015-08-19 11:30:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296723005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296723005/1
5 years, 4 months ago (2015-08-20 11:22:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/59063) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-20 11:24:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296723005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296723005/20001
5 years, 4 months ago (2015-08-20 11:35:25 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 12:14:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200897

Powered by Google App Engine
This is Rietveld 408576698