Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: public/platform/modules/serviceworker/WebServiceWorkerCache.h

Issue 1296723005: [CacheStorage] Use appopriate type parameters for WebCallbacks (3/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/modules/serviceworker/WebServiceWorkerCache.h
diff --git a/public/platform/modules/serviceworker/WebServiceWorkerCache.h b/public/platform/modules/serviceworker/WebServiceWorkerCache.h
index 17c9ad0cf39934b81a106918aa886d7a85325966..5417b2239c7162960b45f3b932a5cf319289a5fe 100644
--- a/public/platform/modules/serviceworker/WebServiceWorkerCache.h
+++ b/public/platform/modules/serviceworker/WebServiceWorkerCache.h
@@ -20,39 +20,9 @@ namespace blink {
// This object is owned by Blink, and should be destroyed as each Cache instance is no longer in use.
class WebServiceWorkerCache {
public:
- class CacheMatchCallbacks : public WebCallbacks<const WebServiceWorkerResponse&, WebServiceWorkerCacheError> {
- public:
- void onSuccess(WebServiceWorkerResponse* r) { onSuccess(*r); }
- void onError(WebServiceWorkerCacheError* e)
- {
- onError(*e);
- delete e;
- }
- void onSuccess(const WebServiceWorkerResponse&) override {}
- void onError(WebServiceWorkerCacheError) override {}
- };
- class CacheWithResponsesCallbacks : public WebCallbacks<const WebVector<WebServiceWorkerResponse>&, WebServiceWorkerCacheError> {
- public:
- void onSuccess(WebVector<WebServiceWorkerResponse>* r) { onSuccess(*r); }
- void onError(WebServiceWorkerCacheError* e)
- {
- onError(*e);
- delete e;
- }
- void onSuccess(const WebVector<WebServiceWorkerResponse>&) override {}
- void onError(WebServiceWorkerCacheError) override {}
- };
- class CacheWithRequestsCallbacks : public WebCallbacks<const WebVector<WebServiceWorkerRequest>&, WebServiceWorkerCacheError> {
- public:
- void onSuccess(WebVector<WebServiceWorkerRequest>* r) { onSuccess(*r); }
- void onError(WebServiceWorkerCacheError* e)
- {
- onError(*e);
- delete e;
- }
- void onSuccess(const WebVector<WebServiceWorkerRequest>&) override {}
- void onError(WebServiceWorkerCacheError) override {}
- };
+ using CacheMatchCallbacks = WebCallbacks<const WebServiceWorkerResponse&, WebServiceWorkerCacheError>;
+ using CacheWithResponsesCallbacks = WebCallbacks<const WebVector<WebServiceWorkerResponse>&, WebServiceWorkerCacheError>;
+ using CacheWithRequestsCallbacks = WebCallbacks<const WebVector<WebServiceWorkerRequest>&, WebServiceWorkerCacheError>;
using CacheBatchCallbacks = WebCallbacks<void, WebServiceWorkerCacheError>;
virtual ~WebServiceWorkerCache() { }
« no previous file with comments | « no previous file | public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698