Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 1296713007: Record slots in large objects. (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Record slots in large objects. BUG= Committed: https://crrev.com/43f3303838e6343c1b81da06124f34ca531c0382 Cr-Commit-Position: refs/heads/master@{#30299}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -28 lines) Patch
M src/heap/gc-tracer.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/gc-tracer.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M test/cctest/cctest.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Hannes Payer (out of office)
5 years, 4 months ago (2015-08-20 11:08:29 UTC) #2
Michael Lippautz
lgtm % nits https://codereview.chromium.org/1296713007/diff/40001/test/cctest/cctest.h File test/cctest/cctest.h (right): https://codereview.chromium.org/1296713007/diff/40001/test/cctest/cctest.h#newcode559 test/cctest/cctest.h:559: bool complete = true) { nit: ...
5 years, 4 months ago (2015-08-20 11:14:39 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1296713007/diff/40001/test/cctest/cctest.h File test/cctest/cctest.h (right): https://codereview.chromium.org/1296713007/diff/40001/test/cctest/cctest.h#newcode559 test/cctest/cctest.h:559: bool complete = true) { On 2015/08/20 11:14:39, Michael ...
5 years, 4 months ago (2015-08-20 11:39:17 UTC) #4
Michael Lippautz
On 2015/08/20 11:39:17, Hannes Payer wrote: > https://codereview.chromium.org/1296713007/diff/40001/test/cctest/cctest.h > File test/cctest/cctest.h (right): > > https://codereview.chromium.org/1296713007/diff/40001/test/cctest/cctest.h#newcode559 ...
5 years, 4 months ago (2015-08-20 12:13:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296713007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296713007/60001
5 years, 4 months ago (2015-08-21 10:42:08 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-21 11:41:50 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 11:42:01 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/43f3303838e6343c1b81da06124f34ca531c0382
Cr-Commit-Position: refs/heads/master@{#30299}

Powered by Google App Engine
This is Rietveld 408576698