Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: test/cctest/cctest.h

Issue 1296713007: Record slots in large objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/mark-compact.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/cctest.h
diff --git a/test/cctest/cctest.h b/test/cctest/cctest.h
index 5c19195208eaaa88b3647c0559dab2691ce9f2f3..61e3c962842c6edc8e3431048ba2aa20d8aca535 100644
--- a/test/cctest/cctest.h
+++ b/test/cctest/cctest.h
@@ -555,7 +555,8 @@ static inline void SimulateFullSpace(v8::internal::PagedSpace* space) {
// Helper function that simulates many incremental marking steps until
// marking is completed.
-static inline void SimulateIncrementalMarking(i::Heap* heap) {
+static inline void SimulateIncrementalMarking(i::Heap* heap,
+ bool force_completion = true) {
i::MarkCompactCollector* collector = heap->mark_compact_collector();
i::IncrementalMarking* marking = heap->incremental_marking();
if (collector->sweeping_in_progress()) {
@@ -566,6 +567,8 @@ static inline void SimulateIncrementalMarking(i::Heap* heap) {
marking->Start(i::Heap::kNoGCFlags);
}
CHECK(marking->IsMarking());
+ if (!force_completion) return;
+
while (!marking->IsComplete()) {
marking->Step(i::MB, i::IncrementalMarking::NO_GC_VIA_STACK_GUARD);
if (marking->IsReadyToOverApproximateWeakClosure()) {
« no previous file with comments | « src/heap/mark-compact.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698