Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: components/proxy_config/proxy_config_pref_names.h

Issue 1296663003: Componentize proxy code from chrome/browser/net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated gn build Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/proxy_config/proxy_config_pref_names.h
diff --git a/components/proxy_config/proxy_config_pref_names.h b/components/proxy_config/proxy_config_pref_names.h
new file mode 100644
index 0000000000000000000000000000000000000000..413f19983ffc1687c7292c1b1bc498bb98ac699b
--- /dev/null
+++ b/components/proxy_config/proxy_config_pref_names.h
@@ -0,0 +1,19 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
droger 2015/08/19 09:18:46 Remove (c)
Abhishek 2015/08/19 10:10:29 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONETS_PROXY_CONFIG_PROXY_CONFIG_PREF_NAMES_H_
+#define COMPONETS_PROXY_CONFIG_PROXY_CONFIG_PREF_NAMES_H_
+
+#include "components/proxy_config/proxy_config_export.h"
+
+namespace ProxyPrefs {
+
+namespace prefs {
+
+// Preference to store proxy settings.
droger 2015/08/19 09:18:45 Move this comment to the .cc file, to be consisten
Abhishek 2015/08/19 10:10:29 Done.
+PROXY_CONFIG_EXPORT extern const char kProxy[];
+
+} // namespace prefs
droger 2015/08/19 09:18:46 Add blank line here, or remove blank line 11, to b
Abhishek 2015/08/19 10:10:29 Done.
+} // namespace ProxyPrefs
droger 2015/08/19 09:18:46 Blank line before #endif.
Abhishek 2015/08/19 10:10:29 Done.
+#endif // COMPONETS_PROXY_CONFIG_PROXY_CONFIG_PREF_NAMES_H_

Powered by Google App Engine
This is Rietveld 408576698