components/proxy_config/proxy_config_pref_names.h - Issue 1296663003: Componentize proxy code from chrome/browser/net

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/proxy_config/proxy_config_pref_names.h

Issue 1296663003: Componentize proxy code from chrome/browser/net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated gn build Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/proxy_config/pref_proxy_config_tracker_impl.h ('K') | « components/proxy_config/pref_proxy_config_tracker_impl.cc ('k') | components/proxy_config/proxy_config_pref_names.cc » ('j') | components/proxy_config/proxy_config_pref_names.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
	droger 2015/08/19 09:18:46 Remove (c) Remove (c) Abhishek 2015/08/19 10:10:29 Done. Show quoted text On 2015/08/19 09:18:46, droger wrote: > Remove (c) Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONETS_PROXY_CONFIG_PROXY_CONFIG_PREF_NAMES_H_

	6 #define COMPONETS_PROXY_CONFIG_PROXY_CONFIG_PREF_NAMES_H_

	7

	8 #include "components/proxy_config/proxy_config_export.h"

	9

	10 namespace ProxyPrefs {

	11

	12 namespace prefs {

	13

	14 // Preference to store proxy settings.
	droger 2015/08/19 09:18:45 Move this comment to the .cc file, to be consisten Move this comment to the .cc file, to be consistent with other pref files. Abhishek 2015/08/19 10:10:29 Done. Show quoted text On 2015/08/19 09:18:45, droger wrote: > Move this comment to the .cc file, to be consistent with other pref files. Done.
	15 PROXY_CONFIG_EXPORT extern const char kProxy[];

	16

	17 } // namespace prefs
	droger 2015/08/19 09:18:46 Add blank line here, or remove blank line 11, to b Add blank line here, or remove blank line 11, to be consistent. Abhishek 2015/08/19 10:10:29 Done. Show quoted text On 2015/08/19 09:18:46, droger wrote: > Add blank line here, or remove blank line 11, to be consistent. Done.
	18 } // namespace ProxyPrefs
	droger 2015/08/19 09:18:46 Blank line before #endif. Blank line before #endif. Abhishek 2015/08/19 10:10:29 Done. Show quoted text On 2015/08/19 09:18:46, droger wrote: > Blank line before #endif. Done.
	19 #endif // COMPONETS_PROXY_CONFIG_PROXY_CONFIG_PREF_NAMES_H_

OLD	NEW