Componentize proxy code from chrome/browser/net

components/proxy_config/proxy_config_pref_names.h

Index: components/proxy_config/proxy_config_pref_names.h
diff --git a/components/proxy_config/proxy_config_pref_names.h b/components/proxy_config/proxy_config_pref_names.h
new file mode 100644
index 0000000000000000000000000000000000000000..fa8d92f625b5496f9a43f63f613fca09ae56fcfd
--- /dev/null
+++ b/components/proxy_config/proxy_config_pref_names.h
@@ -0,0 +1,19 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONETS_PROXY_CONFIG_PROXY_CONFIG_PREF_NAMES_H_

[eroman, 2015/08/27 01:16:33]

typo: COMPONENTS_....

[Abhishek, 2015/08/27 06:38:16]

Done.

+#define COMPONETS_PROXY_CONFIG_PROXY_CONFIG_PREF_NAMES_H_
+
+#include "components/proxy_config/proxy_config_export.h"
+
+namespace ProxyPrefs {

[eroman, 2015/08/27 01:16:33]

Isn't Chromium style to use lower-case namespace?
Perhaps this should be proxy_config (to match the component name), or
proxy_prefs

[Abhishek, 2015/08/27 06:38:16]

I feel it would be good if we keep it "proxy_config" as you mentioned to match
component name.

I'll make the necessary changes.

+namespace prefs {

[eroman, 2015/08/27 01:16:33]

why keep the prefs inner namespace? Although I see other components doing
similarly, so maybe fine for consistency.

[Abhishek, 2015/08/27 06:38:16]

Yeah! I also think the same. For consistency it would be good.

+
+PROXY_CONFIG_EXPORT extern const char kProxy[];
+
+}  // namespace prefs
+}  // namespace ProxyPrefs
+
+#endif  // COMPONETS_PROXY_CONFIG_PROXY_CONFIG_PREF_NAMES_H_
+