components/proxy_config/proxy_config_pref_names.h - Issue 1296663003: Componentize proxy code from chrome/browser/net

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/proxy_config/proxy_config_pref_names.h

Issue 1296663003: Componentize proxy code from chrome/browser/net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added thread_checker_.DetachFromThread Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONETS_PROXY_CONFIG_PROXY_CONFIG_PREF_NAMES_H_
	eroman 2015/08/27 01:16:33 typo: COMPONENTS_.... typo: COMPONENTS_.... Abhishek 2015/08/27 06:38:16 Done. Show quoted text On 2015/08/27 01:16:33, eroman wrote: > typo: COMPONENTS_.... Done.
	6 #define COMPONETS_PROXY_CONFIG_PROXY_CONFIG_PREF_NAMES_H_

	7

	8 #include "components/proxy_config/proxy_config_export.h"

	9

	10 namespace ProxyPrefs {
	eroman 2015/08/27 01:16:33 Isn't Chromium style to use lower-case namespace? Isn't Chromium style to use lower-case namespace? Perhaps this should be proxy_config (to match the component name), or proxy_prefs Abhishek 2015/08/27 06:38:16 I feel it would be good if we keep it "proxy_confi Show quoted text On 2015/08/27 01:16:33, eroman wrote: > Isn't Chromium style to use lower-case namespace? > Perhaps this should be proxy_config (to match the component name), or I feel it would be good if we keep it "proxy_config" as you mentioned to match component name. I'll make the necessary changes. Show quoted text > proxy_prefs
	11 namespace prefs {
	eroman 2015/08/27 01:16:33 why keep the prefs inner namespace? Although I see why keep the prefs inner namespace? Although I see other components doing similarly, so maybe fine for consistency. Abhishek 2015/08/27 06:38:16 Yeah! I also think the same. For consistency it wo Show quoted text On 2015/08/27 01:16:33, eroman wrote: > why keep the prefs inner namespace? Although I see other components doing > similarly, so maybe fine for consistency. Yeah! I also think the same. For consistency it would be good.
	12

	13 PROXY_CONFIG_EXPORT extern const char kProxy[];

	14

	15 } // namespace prefs

	16 } // namespace ProxyPrefs

	17

	18 #endif // COMPONETS_PROXY_CONFIG_PROXY_CONFIG_PREF_NAMES_H_

	19

OLD	NEW

« no previous file with comments | « components/proxy_config/pref_proxy_config_tracker_impl.cc ('k') | components/proxy_config/proxy_config_pref_names.cc » ('j') | no next file with comments »