Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1296623003: Adds components/history tests to BUILD.gn (Closed)

Created:
5 years, 4 months ago by sky
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds components/history tests to BUILD.gn Not sure why they weren't added previously. BUG=none TEST=none R=brettw@chromium.org Committed: https://crrev.com/8131b22271b84b2d1fc7d2ca23b0b0ae79484e64 Cr-Commit-Position: refs/heads/master@{#343425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M components/history/content/browser/BUILD.gn View 1 chunk +13 lines, -0 lines 0 comments Download
M components/history/core/browser/BUILD.gn View 1 chunk +41 lines, -0 lines 0 comments Download
M components/history/core/common/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
5 years, 4 months ago (2015-08-14 16:14:58 UTC) #1
brettw
lgtm
5 years, 4 months ago (2015-08-14 17:03:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296623003/1
5 years, 4 months ago (2015-08-14 17:18:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 17:47:43 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 17:48:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8131b22271b84b2d1fc7d2ca23b0b0ae79484e64
Cr-Commit-Position: refs/heads/master@{#343425}

Powered by Google App Engine
This is Rietveld 408576698