Add buildbot_spec info for Appurify bot

Add buildbot_spec info for Appurify bot

BUG=skia:4093
Committed: https://skia.googlesource.com/skia/+/98f7e334e7c5ac28758c926969e5febc33c22959

[borenet, 2015-08-20 16:54:55]

borenet@google.com changed reviewers:
+ djsollen@google.com, mtklein@google.com

[borenet, 2015-08-20 16:54:55]

Also fixes some other buildbot_spec issues.

[mtklein, 2015-08-24 15:31:42]

lgtm, with little things

https://codereview.chromium.org/1296593003/diff/20001/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1296593003/diff/20001/tools/buildbot_spec.py#...
tools/buildbot_spec.py:166: if builder_dict.get('extra_config') == 'Appurify':
Note why?

https://codereview.chromium.org/1296593003/diff/20001/tools/buildbot_spec.py#...
tools/buildbot_spec.py:183: if 'Appurify' in builder_dict.get('extra_config',
''):
Is there a practical difference between

if builder_dict.get('extra_config') == 'Appurify' and 'Appurify' in
builder_dict.get('extra_config', '')?  Will there be Appurify variants?

[borenet, 2015-08-24 16:47:40]

https://codereview.chromium.org/1296593003/diff/20001/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1296593003/diff/20001/tools/buildbot_spec.py#...
tools/buildbot_spec.py:166: if builder_dict.get('extra_config') == 'Appurify':
On 2015/08/24 15:31:42, mtklein wrote:
> Note why?

Done.

https://codereview.chromium.org/1296593003/diff/20001/tools/buildbot_spec.py#...
tools/buildbot_spec.py:183: if 'Appurify' in builder_dict.get('extra_config',
''):
On 2015/08/24 15:31:42, mtklein wrote:
> Is there a practical difference between
> 
> if builder_dict.get('extra_config') == 'Appurify' and 'Appurify' in
> builder_dict.get('extra_config', '')?  Will there be Appurify variants?

No, not really.  This is just how I happened to code it this time.  It's not
unimaginable that we might have an "Appurify_SomeOtherConfig" bot, but it's not
likely.  I'll change it if you want.

[mtklein, 2015-08-24 17:35:33]

https://codereview.chromium.org/1296593003/diff/20001/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1296593003/diff/20001/tools/buildbot_spec.py#...
tools/buildbot_spec.py:183: if 'Appurify' in builder_dict.get('extra_config',
''):
On 2015/08/24 16:47:39, borenet wrote:
> On 2015/08/24 15:31:42, mtklein wrote:
> > Is there a practical difference between
> > 
> > if builder_dict.get('extra_config') == 'Appurify' and 'Appurify' in
> > builder_dict.get('extra_config', '')?  Will there be Appurify variants?
> 
> No, not really.  This is just how I happened to code it this time.  It's not
> unimaginable that we might have an "Appurify_SomeOtherConfig" bot, but it's
not
> likely.  I'll change it if you want.

Let's change one or the other so it's consistent?  Both read fine to me, but it
got me thinking something more subtle was going on here to see it written two
different ways.

[borenet, 2015-08-24 18:31:48]

https://codereview.chromium.org/1296593003/diff/20001/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1296593003/diff/20001/tools/buildbot_spec.py#...
tools/buildbot_spec.py:183: if 'Appurify' in builder_dict.get('extra_config',
''):
On 2015/08/24 17:35:33, mtklein wrote:
> On 2015/08/24 16:47:39, borenet wrote:
> > On 2015/08/24 15:31:42, mtklein wrote:
> > > Is there a practical difference between
> > > 
> > > if builder_dict.get('extra_config') == 'Appurify' and 'Appurify' in
> > > builder_dict.get('extra_config', '')?  Will there be Appurify variants?
> > 
> > No, not really.  This is just how I happened to code it this time.  It's not
> > unimaginable that we might have an "Appurify_SomeOtherConfig" bot, but it's
> not
> > likely.  I'll change it if you want.
> 
> Let's change one or the other so it's consistent?  Both read fine to me, but
it
> got me thinking something more subtle was going on here to see it written two
> different ways.

No more subtlety.

[mtklein, 2015-08-24 19:33:36]

lgtm

[borenet, 2015-08-24 19:45:00]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2015-08-24 19:45:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1296593003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1296593003/60001

[commit-bot: I haz the power, 2015-08-24 19:51:04]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/98f7e334e7c5ac28758c926969e5febc33c22959