Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: tools/buildbot_spec.py

Issue 1296593003: Add buildbot_spec info for Appurify bot (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rewrite Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/buildbot_spec.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/buildbot_spec.py
diff --git a/tools/buildbot_spec.py b/tools/buildbot_spec.py
index 9830e4528961ce9cd15366fe8751af89bd49eb9f..e9498decdb58140379a4297b8c0900adf7e0d5b6 100755
--- a/tools/buildbot_spec.py
+++ b/tools/buildbot_spec.py
@@ -162,6 +162,13 @@ def get_extra_env_vars(builder_dict):
elif builder_dict.get('compiler') == 'Clang':
env['CC'] = '/usr/bin/clang'
env['CXX'] = '/usr/bin/clang++'
+
+ # Force Debug mode for Appurify bots so that we don't have to sign the test
+ # APK.
+ # TODO(borenet): Remove this once able.
+ if builder_dict.get('extra_config') == 'Appurify':
+ env['BUILDTYPE'] = CONFIG_DEBUG
+
return env
@@ -176,7 +183,10 @@ def build_targets_from_builder_dict(builder_dict):
t.append('nanobench')
return t
elif builder_dict['role'] == builder_name_schema.BUILDER_ROLE_PERF:
- return ['nanobench']
+ if builder_dict.get('extra_config') == 'Appurify':
+ return ['VisualBenchTest_APK']
+ else:
+ return ['nanobench']
else:
return ['most']
@@ -300,10 +310,12 @@ def self_test():
'Build-Ubuntu-GCC-x86_64-Release-Mesa',
'Housekeeper-PerCommit',
'Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot',
+ 'Perf-Android-GCC-Nexus5-GPU-Adreno330-Arm7-Release-Appurify',
'Test-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Debug',
'Test-ChromeOS-GCC-Link-CPU-AVX-x86_64-Debug',
'Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug',
'Test-Mac10.8-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Release',
+ 'Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage',
'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD',
'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared',
'Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind',
« no previous file with comments | « tools/buildbot_spec.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698