Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1296573002: Returning const by ref instead of const by value in PresentationSession::id (Closed)

Created:
5 years, 4 months ago by Paritosh Kumar
Modified:
5 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Returning const by ref instead of const by value in PresentationSession::id BUG=393155 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/presentation/PresentationSession.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Paritosh Kumar
PTAL.
5 years, 4 months ago (2015-08-14 12:16:10 UTC) #2
mlamouri (slow - plz ping)
lgtm
5 years, 4 months ago (2015-08-14 12:59:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296573002/1
5 years, 4 months ago (2015-08-14 12:59:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93266)
5 years, 4 months ago (2015-08-14 15:07:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296573002/1
5 years, 4 months ago (2015-08-15 15:24:05 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 16:24:09 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200609

Powered by Google App Engine
This is Rietveld 408576698