Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: Source/modules/presentation/PresentationSession.h

Issue 1296573002: Returning const by ref instead of const by value in PresentationSession::id (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PresentationSession_h 5 #ifndef PresentationSession_h
6 #define PresentationSession_h 6 #define PresentationSession_h
7 7
8 #include "core/events/EventTarget.h" 8 #include "core/events/EventTarget.h"
9 #include "core/fileapi/Blob.h" 9 #include "core/fileapi/Blob.h"
10 #include "core/fileapi/FileError.h" 10 #include "core/fileapi/FileError.h"
(...skipping 25 matching lines...) Expand all
36 static PresentationSession* take(ScriptPromiseResolver*, PassOwnPtr<WebPrese ntationSessionClient>); 36 static PresentationSession* take(ScriptPromiseResolver*, PassOwnPtr<WebPrese ntationSessionClient>);
37 static PresentationSession* take(PresentationController*, PassOwnPtr<WebPres entationSessionClient>); 37 static PresentationSession* take(PresentationController*, PassOwnPtr<WebPres entationSessionClient>);
38 ~PresentationSession() override; 38 ~PresentationSession() override;
39 39
40 // EventTarget implementation. 40 // EventTarget implementation.
41 const AtomicString& interfaceName() const override; 41 const AtomicString& interfaceName() const override;
42 ExecutionContext* executionContext() const override; 42 ExecutionContext* executionContext() const override;
43 43
44 DECLARE_VIRTUAL_TRACE(); 44 DECLARE_VIRTUAL_TRACE();
45 45
46 const String id() const { return m_id; } 46 const String& id() const { return m_id; }
47 const WTF::AtomicString& state() const; 47 const WTF::AtomicString& state() const;
48 48
49 void send(const String& message, ExceptionState&); 49 void send(const String& message, ExceptionState&);
50 void send(PassRefPtr<DOMArrayBuffer>, ExceptionState&); 50 void send(PassRefPtr<DOMArrayBuffer>, ExceptionState&);
51 void send(PassRefPtr<DOMArrayBufferView>, ExceptionState&); 51 void send(PassRefPtr<DOMArrayBufferView>, ExceptionState&);
52 void send(Blob*, ExceptionState&); 52 void send(Blob*, ExceptionState&);
53 void close(); 53 void close();
54 54
55 String binaryType() const; 55 String binaryType() const;
56 void setBinaryType(const String&); 56 void setBinaryType(const String&);
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 // For Blob data handling. 117 // For Blob data handling.
118 Member<BlobLoader> m_blobLoader; 118 Member<BlobLoader> m_blobLoader;
119 Deque<OwnPtr<Message>> m_messages; 119 Deque<OwnPtr<Message>> m_messages;
120 120
121 BinaryType m_binaryType; 121 BinaryType m_binaryType;
122 }; 122 };
123 123
124 } // namespace blink 124 } // namespace blink
125 125
126 #endif // PresentationSession_h 126 #endif // PresentationSession_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698