Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: gyp/jsoncpp.gyp

Issue 12963002: Refactor skia_warnings_as_errors (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Use variable instead of disable_warnings_as_errors.gypi Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gyp/jsoncpp.gyp
===================================================================
--- gyp/jsoncpp.gyp (revision 8310)
+++ gyp/jsoncpp.gyp (working copy)
@@ -12,6 +12,9 @@
# and https://code.google.com/p/skia/source/detail?r=7115
{
+ 'variables': {
+ 'skia_warnings_as_errors': 0,
+ },
'targets': [
{
'target_name': 'jsoncpp',
@@ -47,31 +50,11 @@
],
},
'conditions': [
- [ 'skia_os == "mac"', {
- 'xcode_settings': {
- 'OTHER_CPLUSPLUSFLAGS!': [
- '-Werror',
- ]
- },
- }],
- [ 'skia_os == "win"', {
- 'msvs_settings': {
- 'VCCLCompilerTool': {
- 'WarnAsError': 'false',
- },
- },
- }],
[ 'skia_os == "android"', {
'cflags!': [
'-Wall',
- '-Werror',
],
}],
- ['skia_os in ["linux", "freebsd", "openbsd", "solaris", "nacl"]', {
- 'cflags!': [
- '-Werror',
- ],
- }],
],
},
],
« gyp/cityhash.gyp ('K') | « gyp/common_variables.gypi ('k') | gyp/libjpeg.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698