Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: gyp/libjpeg.gyp

Issue 12963002: Refactor skia_warnings_as_errors (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Use variable instead of disable_warnings_as_errors.gypi Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gyp/cityhash.gyp ('K') | « gyp/jsoncpp.gyp ('k') | gyp/utils.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/libjpeg.gyp
===================================================================
--- gyp/libjpeg.gyp (revision 8310)
+++ gyp/libjpeg.gyp (working copy)
@@ -11,6 +11,7 @@
{
'variables': {
'use_system_libjpeg%': 0,
+ 'skia_warnings_as_errors': 0,
},
'conditions': [
['skia_os == "android"', {
@@ -95,24 +96,12 @@
],
},
'conditions': [
- ['OS!="win"', {
+ [ 'skia_os != "win"', {
'product_name': 'jpeg',
'cflags': [
'-Wno-main', # supresses warnings about naming things "main"
],
}],
- ['OS=="android"', {
- 'cflags!': [
- '-fno-rtti', # supresses warnings about invalid option of non-C++ code
- '-Wall',
- '-Werror',
- ],
- }],
- ['OS in ["linux", "freebsd", "openbsd", "solaris", "nacl"]', {
- 'cflags!': [
- '-Werror',
- ],
- }],
],
},
],
« gyp/cityhash.gyp ('K') | « gyp/jsoncpp.gyp ('k') | gyp/utils.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698