Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Issue 129603002: Re-enable ExtensionSettingsApiTest after removing the "throttling" JS test (Closed)

Created:
6 years, 11 months ago by not at google - send to devlin
Modified:
6 years, 11 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Re-enable ExtensionSettingsApiTest after removing the "throttling" JS test which is extremely slow. BUG=248032 R=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -39 lines) Patch
M chrome/browser/extensions/api/storage/settings_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/settings/simple_test/background.js View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
6 years, 11 months ago (2014-01-08 22:08:00 UTC) #1
Yoyo Zhou
LGTM
6 years, 11 months ago (2014-01-08 22:39:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/129603002/1
6 years, 11 months ago (2014-01-08 22:49:34 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 12:55:39 UTC) #4
Message was sent while issue was closed.
Change committed as 243877

Powered by Google App Engine
This is Rietveld 408576698