chrome/browser/extensions/api/storage/settings_apitest.cc - Issue 129603002: Re-enable ExtensionSettingsApiTest after removing the "throttling" JS test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/settings_apitest.cc

Issue 129603002: Re-enable ExtensionSettingsApiTest after removing the "throttling" JS test (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/storage/settings_apitest.cc

diff --git a/chrome/browser/extensions/api/storage/settings_apitest.cc b/chrome/browser/extensions/api/storage/settings_apitest.cc

index 146cccd225b04ce2245c1c8a729265e80f67d8ea..2b5e72e5773d475032f04560a24c5f5eae56f813 100644

--- a/chrome/browser/extensions/api/storage/settings_apitest.cc

+++ b/chrome/browser/extensions/api/storage/settings_apitest.cc

@@ -251,8 +251,7 @@ class ExtensionSettingsApiTest : public ExtensionApiTest {

#endif

};

-// Flaky. http://crbug.com/248032

-IN_PROC_BROWSER_TEST_F(ExtensionSettingsApiTest, DISABLED_SimpleTest) {

+IN_PROC_BROWSER_TEST_F(ExtensionSettingsApiTest, SimpleTest) {

ASSERT_TRUE(RunExtensionTest("settings/simple_test")) << message_;

}

« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/settings/simple_test/background.js » ('j') | no next file with comments »