[MD settings] adding mock up of location page

[MD settings] adding mock up of location page

This is a non-functional work in progress.

BUG=517564
TBR=grt@chromium.org

Committed: https://crrev.com/e237e747b7e4dcdacbe734e03c465878692b7850
Cr-Commit-Position: refs/heads/master@{#345457}

[dschuyler, 2015-08-14 21:24:46]

dschuyler@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dschuyler, 2015-08-17 20:59:42]

I noticed that I left some junk class names in there.  Those have been removed.

[michaelpg, 2015-08-17 21:09:58]

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/advanced_page/advanced_page.html (right):

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/advanced_page/advanced_page.html:24:
<cr-settings-section route="location"
add to routes.html

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/location_page/location_page.html (right):

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/location_page/location_page.html:3: <link
rel="import"
href="chrome://resources/polymer/v1_0/paper-item/paper-icon-item.html">
nit: alphabetize

I guess it's more than a nit now that we work for a company owned by Alphabet
though.

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/location_page/location_page.html:15:
<iron-icon icon="communication:location-on" item-icon></iron-icon>
import communication-icons

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/location_page/location_page.html:26:
</div>&nbsp;-&nbsp;<span>{{block.length}}</span>
looks like block.length should be an i18n param (loadTimeData.getStringF) as
"String - Number" doesn't necessarily translate

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/location_page/location_page.html:37:
</div>&nbsp;-&nbsp;<span>{{allow.length}}</span>
ditto

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/location_page/location_page.js (right):

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/location_page/location_page.js:8: * security
settings.
location settings

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/location_page/location_page.js:71: block: {
Comment that these are arrays of URLs.

[dschuyler, 2015-08-17 21:48:18]

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/advanced_page/advanced_page.html (right):

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/advanced_page/advanced_page.html:24:
<cr-settings-section route="location"
On 2015/08/17 21:09:58, michaelpg wrote:
> add to routes.html

Done.

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/location_page/location_page.html (right):

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/location_page/location_page.html:3: <link
rel="import"
href="chrome://resources/polymer/v1_0/paper-item/paper-icon-item.html">
On 2015/08/17 21:09:58, michaelpg wrote:
> nit: alphabetize
> 
> I guess it's more than a nit now that we work for a company owned by Alphabet
> though.

Done.

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/location_page/location_page.html:15:
<iron-icon icon="communication:location-on" item-icon></iron-icon>
On 2015/08/17 21:09:58, michaelpg wrote:
> import communication-icons

Done.

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/location_page/location_page.html:26:
</div>&nbsp;-&nbsp;<span>{{block.length}}</span>
On 2015/08/17 21:09:58, michaelpg wrote:
> looks like block.length should be an i18n param (loadTimeData.getStringF) as
> "String - Number" doesn't necessarily translate

Done.

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/location_page/location_page.html:37:
</div>&nbsp;-&nbsp;<span>{{allow.length}}</span>
On 2015/08/17 21:09:58, michaelpg wrote:
> ditto

Done.

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/location_page/location_page.js (right):

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/location_page/location_page.js:8: * security
settings.
On 2015/08/17 21:09:58, michaelpg wrote:
> location settings

I tried to reword this to be more clear.

https://codereview.chromium.org/1295903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/location_page/location_page.js:71: block: {
On 2015/08/17 21:09:58, michaelpg wrote:
> Comment that these are arrays of URLs.

Done.

[michaelpg, 2015-08-17 22:06:54]

lgtm

https://codereview.chromium.org/1295903004/diff/40001/chrome/app/settings_str...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/1295903004/diff/40001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:219: <message
name="IDS_SETTINGS_TITLE_AND_COUNT" desc="A catagory title and count of elements
in that catagory">
nit: "category" (x2)

[dschuyler, 2015-08-17 22:43:44]

https://codereview.chromium.org/1295903004/diff/40001/chrome/app/settings_str...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/1295903004/diff/40001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:219: <message
name="IDS_SETTINGS_TITLE_AND_COUNT" desc="A catagory title and count of elements
in that catagory">
On 2015/08/17 22:06:54, michaelpg wrote:
> nit: "category" (x2)

Done.

[dschuyler, 2015-08-18 01:02:43]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2015-08-18 01:02:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1295903004/#ps60001
(title: "string comment change")

[commit-bot: I haz the power, 2015-08-18 01:04:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1295903004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1295903004/60001

[commit-bot: I haz the power, 2015-08-18 01:14:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 01:14:57]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dschuyler, 2015-08-18 01:23:32]

dschuyler@chromium.org changed reviewers:
+ jhawkins@chromium.org
- michaelpg@chromium.org

[dschuyler, 2015-08-18 01:23:33]

Hi James,  

I added one string that needs review.

PTAL at the settings_strings.grdp and md_settings_localized_strings_provider.cc.

[dschuyler, 2015-08-24 23:23:47]

dschuyler@chromium.org changed reviewers:
+ dbeam@chromium.org
- jhawkins@chromium.org

[dschuyler, 2015-08-24 23:24:41]

Hi Dan, Could you review the file:
md_settings_localized_strings_provider.cc

[Dan Beam, 2015-08-24 23:33:18]

lgtm w/nit

https://codereview.chromium.org/1295903004/diff/60001/chrome/app/settings_str...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/1295903004/diff/60001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:219: <message
name="IDS_SETTINGS_TITLE_AND_COUNT" desc="A title and count of elements in that
catagory">
category

https://codereview.chromium.org/1295903004/diff/60001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:219: <message
name="IDS_SETTINGS_TITLE_AND_COUNT" desc="A title and count of elements in that
catagory">
"The title of a section in the settings page with a count of the total number of
items in the section."

[dschuyler, 2015-08-25 21:19:37]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2015-08-25 21:19:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org,
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1295903004/#ps100001
(title: "fixed accidental change in last patch")

[commit-bot: I haz the power, 2015-08-25 21:20:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1295903004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1295903004/100001

[commit-bot: I haz the power, 2015-08-25 22:29:00]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-08-25 22:29:48]

Patchset 6 (id:??) landed as
https://crrev.com/e237e747b7e4dcdacbe734e03c465878692b7850
Cr-Commit-Position: refs/heads/master@{#345457}