chrome/browser/resources/settings/location_page/location_page.html - Issue 1295903004: [MD settings] adding mock up of location page

Side by Side Diff: chrome/browser/resources/settings/location_page/location_page.html

Issue 1295903004: [MD settings] adding mock up of location page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup some temp vars Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/advanced_page/advanced_page.html ('K') | « chrome/browser/resources/settings/location_page/location_page.css ('k') | chrome/browser/resources/settings/location_page/location_page.js » ('j') | chrome/browser/resources/settings/location_page/location_page.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-icon-i tem.html">
	michaelpg 2015/08/17 21:09:58 nit: alphabetize I guess it's more than a nit now nit: alphabetize I guess it's more than a nit now that we work for a company owned by Alphabet though. dschuyler 2015/08/17 21:48:17 Done. Show quoted text On 2015/08/17 21:09:58, michaelpg wrote: > nit: alphabetize > > I guess it's more than a nit now that we work for a company owned by Alphabet > though. Done.
	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item-b ody.html">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-submen u.html">

	7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html">

	8

	9 <dom-module id="cr-settings-location-page">

	10 <link rel="import" type="css"

	11 href="chrome://md-settings/settings_page/settings_page.css">

	12 <link rel="import" type="css" href="location_page.css">

	13 <template>

	14 <paper-icon-item>

	15 <iron-icon icon="communication:location-on" item-icon></iron-icon>
	michaelpg 2015/08/17 21:09:58 import communication-icons import communication-icons dschuyler 2015/08/17 21:48:17 Done. Show quoted text On 2015/08/17 21:09:58, michaelpg wrote: > import communication-icons Done.
	16 <paper-item-body two-line class="flex">

	17 <div i18n-content="siteSettingsLocation"></div>

	18 <div secondary i18n-content="siteSettingsAskBeforeAccessing"></div>

	19 </paper-item-body>

	20 <paper-toggle-button></paper-toggle-button>

	21 </paper-icon-item>

	22 <paper-menu>

	23 <paper-submenu>

	24 <paper-item class="menu-trigger">

	25 <div i18n-content="siteSettingsBlock">

	26 </div> - <span>{{block.length}}</span>
	michaelpg 2015/08/17 21:09:58 looks like block.length should be an i18n param (l looks like block.length should be an i18n param (loadTimeData.getStringF) as "String - Number" doesn't necessarily translate dschuyler 2015/08/17 21:48:17 Done. Show quoted text On 2015/08/17 21:09:58, michaelpg wrote: > looks like block.length should be an i18n param (loadTimeData.getStringF) as > "String - Number" doesn't necessarily translate Done.
	27 </paper-item>

	28 <paper-menu class="menu-content">

	29 <template is="dom-repeat" items="{{block}}">

	30 <paper-item>{{item.url}}</paper-item>

	31 </template>

	32 </paper-menu>

	33 </paper-submenu>

	34 <paper-submenu>

	35 <paper-item class="menu-trigger">

	36 <div i18n-content="siteSettingsAllow">

	37 </div> - <span>{{allow.length}}</span>
	michaelpg 2015/08/17 21:09:58 ditto ditto dschuyler 2015/08/17 21:48:17 Done. Show quoted text On 2015/08/17 21:09:58, michaelpg wrote: > ditto Done.
	38 </paper-item>

	39 <paper-menu class="menu-content">

	40 <template is="dom-repeat" items="{{allow}}">

	41 <paper-item>{{item.url}}</paper-item>

	42 </template>

	43 </paper-menu>

	44 </paper-submenu>

	45 </paper-menu>

	46 </template>

	47 <script src="location_page.js"></script>

	48 </dom-module>

OLD	NEW