Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1295893006: Move computeInlineBoxPosition out from PositionAlgorithm class (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move computeInlineBoxPosition() out from PositionAlgorithm template class This patch moves |computeInlineBoxPosition()| out from |PositionAlgorithm| template class to reduce |InlineBox| dependency in |PositionAlgorithm| class and simplify |PositionAlgorithm| class for improving code health. Following patch will move |computeInlineBoxPosition()| to "VisibleUnits.cpp". BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200906

Patch Set 1 : 2015-08-20T13:18:32 #

Patch Set 2 : 2015-08-20T18:19:45 Rebase #

Patch Set 3 : 2015-08-20T22:30:52 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -25 lines) Patch
M Source/core/editing/Position.h View 1 2 2 chunks +11 lines, -3 lines 0 comments Download
M Source/core/editing/Position.cpp View 1 2 3 chunks +32 lines, -12 lines 0 comments Download
M Source/core/editing/RenderedPosition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295893006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295893006/1
5 years, 4 months ago (2015-08-20 04:20:36 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/22134)
5 years, 4 months ago (2015-08-20 04:49:25 UTC) #4
yosin_UTC9
On 2015/08/20 04:49:25, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
5 years, 4 months ago (2015-08-20 04:59:06 UTC) #5
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-20 05:01:27 UTC) #7
hajimehoshi
lgtm
5 years, 4 months ago (2015-08-20 05:27:42 UTC) #8
yoichio
lgtm
5 years, 4 months ago (2015-08-20 05:44:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295893006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295893006/1
5 years, 4 months ago (2015-08-20 08:25:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/22185) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 4 months ago (2015-08-20 08:28:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295893006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295893006/20001
5 years, 4 months ago (2015-08-20 09:21:07 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/95924)
5 years, 4 months ago (2015-08-20 11:24:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295893006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295893006/20001
5 years, 4 months ago (2015-08-20 11:26:07 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/90595)
5 years, 4 months ago (2015-08-20 11:31:04 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295893006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295893006/40001
5 years, 4 months ago (2015-08-20 13:32:32 UTC) #25
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 15:34:50 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200906

Powered by Google App Engine
This is Rietveld 408576698