Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: Source/core/editing/Position.h

Issue 1295893006: Move computeInlineBoxPosition out from PositionAlgorithm class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-20T22:30:52 Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/editing/Position.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/Position.h
diff --git a/Source/core/editing/Position.h b/Source/core/editing/Position.h
index 6dd1d1093669eab44dc20220cf7e2c0a97f67c6f..d176e728d080fdc7994e5644baeaa3c60822959f 100644
--- a/Source/core/editing/Position.h
+++ b/Source/core/editing/Position.h
@@ -189,9 +189,6 @@ public:
bool isCandidate() const;
- InlineBoxPosition computeInlineBoxPosition(TextAffinity) const;
- InlineBoxPosition computeInlineBoxPosition(TextAffinity, TextDirection primaryDirection) const;
-
static PositionAlgorithm<Strategy> beforeNode(Node* anchorNode);
static PositionAlgorithm<Strategy> afterNode(Node* anchorNode);
static PositionAlgorithm<Strategy> inParentBeforeNode(const Node& anchorNode);
@@ -433,6 +430,17 @@ inline PositionInComposedTree fromPositionInDOMTree<EditingInComposedTreeStrateg
return toPositionInComposedTree(position);
}
+// TODO(yosin) |isRenderedCharacter()| should be removed, and we should use
+// |VisiblePosition::characterAfter()| and |VisiblePosition::characterBefore()|.
+// TODO(yosin) We should move |isRenderedCharacter()| to "VisibleUnits.cpp",
+// since it is used only in "editing/commands/"
+CORE_EXPORT bool isRenderedCharacter(const Position&);
+// TODO(yosin) We should move |computeInlineBoxPosition()| to "VisibleUnits.cpp"
+CORE_EXPORT InlineBoxPosition computeInlineBoxPosition(const Position&, TextAffinity);
+CORE_EXPORT InlineBoxPosition computeInlineBoxPosition(const Position&, TextAffinity, TextDirection primaryDirection);
+CORE_EXPORT InlineBoxPosition computeInlineBoxPosition(const PositionInComposedTree&, TextAffinity);
+CORE_EXPORT InlineBoxPosition computeInlineBoxPosition(const PositionInComposedTree&, TextAffinity, TextDirection primaryDirection);
+
// TODO(yosin) We should move |inRenderedText()| to "VisibleUnits.h" for
// reduce dependency of |LayoutObject| in |Position| class.
CORE_EXPORT bool inRenderedText(const Position&);
« no previous file with comments | « no previous file | Source/core/editing/Position.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698