src/core/SkPMFloat.h - Issue 1295873004: SkColorCubeFilter: require alpha == 0xFF.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPMFloat.h

Issue 1295873004: SkColorCubeFilter: require alpha == 0xFF. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: just perf Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPMFloat.h

diff --git a/src/core/SkPMFloat.h b/src/core/SkPMFloat.h

index 1fc80f50044adc756543d944531db03c695a296c..4a5621f5b3cc62cf6ae11b5173d8f449fcce10ef 100644

--- a/src/core/SkPMFloat.h

+++ b/src/core/SkPMFloat.h

@@ -26,7 +26,7 @@ class SkPMFloat : public Sk4f {

public:

static SkPMFloat FromPMColor(SkPMColor c) { return SkPMFloat(c); }

static SkPMFloat FromARGB(float a, float r, float g, float b) { return SkPMFloat(a,r,g,b); }

- static SkPMFloat FromBGRx(SkColor c); // Ignores c's alpha, instead forcing it to 1.

+ static SkPMFloat FromOpaqueColor(SkColor c); // Requires c's alpha == 0xFF.

Sk4f alphas() const; // argb -> aaaa, generally faster than the equivalent Sk4f(this->a()).