Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1295673003: Revert of 2D canvas: remain in deferred rendering mode with canvas to canvas drawImage (Closed)

Created:
5 years, 4 months ago by leviw_travelin_and_unemployed
Modified:
5 years, 4 months ago
CC:
blink-reviews, krit, blink-reviews-html_chromium.org, drott+blinkwatch_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, danakj, dglazkov+blink, Rik, f(malita), Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of 2D canvas: remain in deferred rendering mode with canvas to canvas drawImage (patchset #2 id:20001 of https://codereview.chromium.org/1288773005/ ) Reason for revert: Appears to be triggering MSAN crashes: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fdisplay_list_2d_canvas%2Ffast%2Fcanvas%2F2d.composite.globalAlpha.fillPath.html&testType=layout-tests Original issue's description: > 2D canvas: remain in deferred rendering mode with canvas to canvas drawImage > > If the source canvas is not animated, no need to exit deferred rendering > because there is no risk of memory bloat due to snapshotting. > > BUG=521001 > TEST=telemetry tough_canvas_cases > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200654 TBR=senorblanco@chromium.org,junov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=521001 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -40 lines) Patch
M Source/core/html/HTMLCanvasElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 2 chunks +6 lines, -15 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.h View 2 chunks +1 line, -8 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.cpp View 2 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
leviw_travelin_and_unemployed
Created Revert of 2D canvas: remain in deferred rendering mode with canvas to canvas drawImage
5 years, 4 months ago (2015-08-17 19:01:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295673003/1
5 years, 4 months ago (2015-08-17 19:01:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200660
5 years, 4 months ago (2015-08-17 19:02:14 UTC) #3
leviw_travelin_and_unemployed
On 2015/08/17 at 19:02:14, commit-bot wrote: > Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200660 The test ...
5 years, 4 months ago (2015-08-17 20:11:58 UTC) #4
Justin Novosad
5 years, 4 months ago (2015-08-17 20:13:59 UTC) #5
Message was sent while issue was closed.
On 2015/08/17 20:11:58, leviw wrote:
> On 2015/08/17 at 19:02:14, commit-bot wrote:
> > Committed patchset #1 (id:1) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=200660
> 
> The test recovered after this revert.

Yep, re-land+fix is on the verge: https://codereview.chromium.org/1289423003/

Powered by Google App Engine
This is Rietveld 408576698