Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1288773005: 2D canvas: remain in deferred rendering mode with canvas to canvas drawImage (Closed)

Created:
5 years, 4 months ago by Justin Novosad
Modified:
5 years, 4 months ago
Reviewers:
Stephen White
CC:
blink-reviews, krit, blink-reviews-html_chromium.org, drott+blinkwatch_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, danakj, dglazkov+blink, Rik, f(malita), Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

2D canvas: remain in deferred rendering mode with canvas to canvas drawImage If the source canvas is not animated, no need to exit deferred rendering because there is no risk of memory bloat due to snapshotting. BUG=521001 TEST=telemetry tough_canvas_cases Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200654

Patch Set 1 #

Total comments: 1

Patch Set 2 : bikeshed #

Patch Set 3 : add init of snapShot state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -10 lines) Patch
M Source/core/html/HTMLCanvasElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 2 chunks +15 lines, -6 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M Source/platform/graphics/ImageBuffer.cpp View 1 2 3 chunks +12 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (2 generated)
Justin Novosad
5 years, 4 months ago (2015-08-17 14:35:28 UTC) #2
Stephen White
Nice optimization! https://codereview.chromium.org/1288773005/diff/1/Source/platform/graphics/ImageBuffer.cpp File Source/platform/graphics/ImageBuffer.cpp (right): https://codereview.chromium.org/1288773005/diff/1/Source/platform/graphics/ImageBuffer.cpp#newcode153 Source/platform/graphics/ImageBuffer.cpp:153: m_animationState = DidAcquireSnapshot; Naming nit: m_drawnToAfterSnapshot or ...
5 years, 4 months ago (2015-08-17 15:15:07 UTC) #3
Justin Novosad
New Patch
5 years, 4 months ago (2015-08-17 16:40:20 UTC) #4
Stephen White
LGTM
5 years, 4 months ago (2015-08-17 16:41:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288773005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288773005/20001
5 years, 4 months ago (2015-08-17 16:54:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200654
5 years, 4 months ago (2015-08-17 18:06:32 UTC) #8
leviw_travelin_and_unemployed
5 years, 4 months ago (2015-08-17 19:01:24 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1295673003/ by leviw@chromium.org.

The reason for reverting is: Appears to be triggering MSAN crashes:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=vir....

Powered by Google App Engine
This is Rietveld 408576698