Separating the two tests into different executions.

Separating the two tests into different executions.

By specifying the gtest_filter to run the two tests separately, we will be restart the host, which allows for independence between the two tests. If the host is not restarted before the 2nd test, the first connection numbers that it obtains is already a reconnect.

BUG=

Committed: https://crrev.com/dbc8c842f35dad1b526d3b89a2945079b84573f0
Cr-Commit-Position: refs/heads/master@{#343290}

[tonychun, 2015-08-13 18:31:06]

tonychun@google.com changed reviewers:
+ anandc@chromium.org, joedow@chromium.org

[tonychun, 2015-08-13 18:33:16]

Separated the two tests to use different hosts.

[anandc, 2015-08-13 18:38:40]

On 2015/08/13 18:33:16, tonychun wrote:
> Separated the two tests to use different hosts.

Could you update the Description to explain why this is being done? It is
because if the host is not restarted before the 2nd test, the first connection
numbers that it obtains is already for a reconnect.

[tonychun, 2015-08-13 19:28:05]

Updated the description to explain the purpose of restarting the host.

[joedow, 2015-08-13 20:04:39]

https://codereview.chromium.org/1295533002/diff/1/remoting/test/chromoting_te...
File remoting/test/chromoting_test_driver_tests.cc (right):

https://codereview.chromium.org/1295533002/diff/1/remoting/test/chromoting_te...
remoting/test/chromoting_test_driver_tests.cc:17: 
To add on to Anand's comments a bit, can you add a comment here to alert the
reader to the problems of running all tests in one instance?  That way anyone
adding tests won't be shocked if they start seeing times which are indicative of
a reconnect vs. a first connect.

https://codereview.chromium.org/1295533002/diff/1/testing/chromoting/chromoti...
File testing/chromoting/chromoting_test_driver_commands_linux.txt (right):

https://codereview.chromium.org/1295533002/diff/1/testing/chromoting/chromoti...
testing/chromoting/chromoting_test_driver_commands_linux.txt:1:
#PROD_DIR#/chromoting_test_driver --username=chromoting.swarming@gmail.com
--refresh-token-path=../../remoting/tools/internal/refresh_tokens.json
--hostname=chromoting-test-driver-host --verbosity=2
--gtest_filter=ChromotingTestFixture.TestMeasurePinBasedAuthentication
--pin=123456
Is it possible to separate these with newlines?  I forget whether the test
launcher handles newlines or not.  If not, no big deal, if so then  please add a
newline here :)

[tonychun, 2015-08-13 21:23:01]

Added comments to notify reader that a test should restart the host before
running.

https://codereview.chromium.org/1295533002/diff/1/remoting/test/chromoting_te...
File remoting/test/chromoting_test_driver_tests.cc (right):

https://codereview.chromium.org/1295533002/diff/1/remoting/test/chromoting_te...
remoting/test/chromoting_test_driver_tests.cc:17: 
On 2015/08/13 20:04:39, joedow wrote:
> To add on to Anand's comments a bit, can you add a comment here to alert the
> reader to the problems of running all tests in one instance?  That way anyone
> adding tests won't be shocked if they start seeing times which are indicative
of
> a reconnect vs. a first connect.

Done.

https://codereview.chromium.org/1295533002/diff/1/testing/chromoting/chromoti...
File testing/chromoting/chromoting_test_driver_commands_linux.txt (right):

https://codereview.chromium.org/1295533002/diff/1/testing/chromoting/chromoti...
testing/chromoting/chromoting_test_driver_commands_linux.txt:1:
#PROD_DIR#/chromoting_test_driver --username=chromoting.swarming@gmail.com
--refresh-token-path=../../remoting/tools/internal/refresh_tokens.json
--hostname=chromoting-test-driver-host --verbosity=2
--gtest_filter=ChromotingTestFixture.TestMeasurePinBasedAuthentication
--pin=123456
On 2015/08/13 20:04:39, joedow wrote:
> Is it possible to separate these with newlines?  I forget whether the test
> launcher handles newlines or not.  If not, no big deal, if so then  please add
a
> newline here :)

Unfortunately I cannot. Here is the output I get when I add a new line.

++++++++++FAILED TESTS++++++++++
[Command failed]: 
++++++++++++++++++++++++++++++++

[anandc, 2015-08-13 21:35:31]

lgtm % comments.

https://codereview.chromium.org/1295533002/diff/20001/remoting/test/chromotin...
File remoting/test/chromoting_test_driver_tests.cc (right):

https://codereview.chromium.org/1295533002/diff/20001/remoting/test/chromotin...
remoting/test/chromoting_test_driver_tests.cc:19: // a previously connected host
will output time the time to reconnect versus the
nit: "output time the time to" -> "output the time to"

https://codereview.chromium.org/1295533002/diff/20001/remoting/test/chromotin...
remoting/test/chromoting_test_driver_tests.cc:45: // does not restart after a
previous connection, then the first connection will
"does not restart" -> "is not restarted"

[tonychun, 2015-08-13 21:39:07]

Made changes to comments.

https://codereview.chromium.org/1295533002/diff/20001/remoting/test/chromotin...
File remoting/test/chromoting_test_driver_tests.cc (right):

https://codereview.chromium.org/1295533002/diff/20001/remoting/test/chromotin...
remoting/test/chromoting_test_driver_tests.cc:19: // a previously connected host
will output time the time to reconnect versus the
On 2015/08/13 21:35:31, anandc wrote:
> nit: "output time the time to" -> "output the time to"

Done.

https://codereview.chromium.org/1295533002/diff/20001/remoting/test/chromotin...
remoting/test/chromoting_test_driver_tests.cc:45: // does not restart after a
previous connection, then the first connection will
On 2015/08/13 21:35:31, anandc wrote:
> "does not restart" -> "is not restarted"

Done.

[joedow, 2015-08-13 22:11:18]

lgtm

[tonychun, 2015-08-13 22:15:09]

The CQ bit was checked by tonychun@google.com

[tonychun, 2015-08-13 22:15:09]

The patchset sent to the CQ was uploaded after l-g-t-m from anandc@chromium.org
Link to the patchset: https://codereview.chromium.org/1295533002/#ps40001
(title: "Nitpick changes.")

[commit-bot: I haz the power, 2015-08-13 22:15:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1295533002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1295533002/40001

[commit-bot: I haz the power, 2015-08-13 22:33:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-13 22:34:23]

Patchset 3 (id:??) landed as
https://crrev.com/dbc8c842f35dad1b526d3b89a2945079b84573f0
Cr-Commit-Position: refs/heads/master@{#343290}