Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: remoting/test/chromoting_test_driver_tests.cc

Issue 1295533002: Separating the two tests into different executions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nitpick changes. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/chromoting/chromoting_test_driver_commands_linux.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/test/chromoting_test_driver_tests.cc
diff --git a/remoting/test/chromoting_test_driver_tests.cc b/remoting/test/chromoting_test_driver_tests.cc
index 2216be64ac66dc143984a52585badcc94b3f7d9a..52c58e6686b38bb7759391f2eed1c6cbe1fcceed 100644
--- a/remoting/test/chromoting_test_driver_tests.cc
+++ b/remoting/test/chromoting_test_driver_tests.cc
@@ -15,6 +15,9 @@ const int kMaxTimeToConnectMs = 2000;
namespace remoting {
namespace test {
+// Note: Make sure to restart the host before running this test. Connecting to
+// a previously connected host will output the time to reconnect versus the time
+// to connect.
TEST_F(ChromotingTestFixture, TestMeasurePinBasedAuthentication) {
bool connected = ConnectToHost(kPinBasedMaxConnectionTimeInSeconds);
EXPECT_TRUE(connected);
@@ -38,6 +41,9 @@ TEST_F(ChromotingTestFixture, TestMeasurePinBasedAuthentication) {
connection_time_observer_->DisplayConnectionStats();
}
+// Note: Make sure to restart the host before running this test. If the host
+// is not restarted after a previous connection, then the first connection will
+// be a reconnect and the second connection will be a second reconnect.
TEST_F(ChromotingTestFixture, TestMeasureReconnectPerformance) {
bool connected = ConnectToHost(kPinBasedMaxConnectionTimeInSeconds);
EXPECT_TRUE(connected);
@@ -58,8 +64,6 @@ TEST_F(ChromotingTestFixture, TestMeasureReconnectPerformance) {
protocol::ConnectionToHost::State::CONNECTED).InMilliseconds();
EXPECT_LE(authenticated_to_connected_time, kMaxTimeToConnectMs);
- connection_time_observer_->DisplayConnectionStats();
-
// Begin reconnection to same host.
connected = ConnectToHost(kPinBasedMaxConnectionTimeInSeconds);
EXPECT_TRUE(connected);
« no previous file with comments | « no previous file | testing/chromoting/chromoting_test_driver_commands_linux.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698