components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/browser/url_request_context_factory.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc ('k') | content/browser/appcache/appcache_storage_impl_unittest.cc » ('j') | content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc

index 0e37cbf6c02c1c012245e48152132ffa705ffc0a..1cf8288bff6518f6b3940f8202cca67bb8d8c294 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc

@@ -74,8 +74,8 @@ class DataReductionProxyNetworkDelegateTest : public testing::Test {

// The |test_job_factory_| takes ownership of the interceptor.

test_job_interceptor_ = new net::TestJobInterceptor();

- EXPECT_TRUE(test_job_factory_.SetProtocolHandler(url::kHttpScheme,

- test_job_interceptor_));

+ EXPECT_TRUE(test_job_factory_.SetProtocolHandler(

+ url::kHttpScheme, make_scoped_ptr(test_job_interceptor_)));

context_.set_job_factory(&test_job_factory_);

test_context_ = DataReductionProxyTestContext::Builder()