content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/browser/url_request_context_factory.cc ('K') | « content/browser/appcache/appcache_update_job_unittest.cc ('k') | content/browser/cache_storage/cache_storage_cache_unittest.cc » ('j') | content/browser/cache_storage/cache_storage_cache_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc

diff --git a/content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc b/content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc

index 99ff06727d3721a5b5348a47a89342e42cf2106a..1d7742056251c12befc50e46d128bea4bd65e55c 100644

--- a/content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc

+++ b/content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc

@@ -117,7 +117,8 @@ class CacheStorageBlobToDiskCacheTest : public testing::Test {

void InitURLRequestJobFactory() {

url_request_job_factory_.reset(new net::URLRequestJobFactoryImpl);

url_request_job_factory_->SetProtocolHandler(

- "blob", CreateMockBlobProtocolHandler(blob_storage_context_));

+ "blob",

+ make_scoped_ptr(CreateMockBlobProtocolHandler(blob_storage_context_)));

davidben 2015/08/18 20:40:37 CreateMockBlobProtocolHandler could just return a

svaldez 2015/08/18 22:12:44 Done.

net::URLRequestContext* url_request_context =

url_request_context_getter_->GetURLRequestContext();