Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: mojo/services/network/url_loader_impl_apptest.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing un-modified file Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/webui/url_data_manager_ios_backend.cc ('k') | net/proxy/proxy_script_fetcher_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/network/url_loader_impl_apptest.cc
diff --git a/mojo/services/network/url_loader_impl_apptest.cc b/mojo/services/network/url_loader_impl_apptest.cc
index 777889a5927c3a820ed4c29e3c1ad1f1fb4eca12..2fb2210f032971cc6cfb07cb85091150f3772364 100644
--- a/mojo/services/network/url_loader_impl_apptest.cc
+++ b/mojo/services/network/url_loader_impl_apptest.cc
@@ -93,7 +93,6 @@ class TestProtocolHandler : public net::URLRequestJobFactory::ProtocolHandler {
return new TestURLRequestJob(request, network_delegate);
}
- private:
~TestProtocolHandler() override {}
};
@@ -112,7 +111,7 @@ class UrlLoaderImplTest : public test::ApplicationTestBase {
scoped_ptr<net::TestURLRequestContext> url_request_context(
new net::TestURLRequestContext(true));
ASSERT_TRUE(url_request_job_factory_.SetProtocolHandler(
- "http", new TestProtocolHandler()));
+ "http", make_scoped_ptr(new TestProtocolHandler())));
url_request_context->set_job_factory(&url_request_job_factory_);
url_request_context->Init();
network_context_.reset(new NetworkContext(url_request_context.Pass()));
« no previous file with comments | « ios/web/webui/url_data_manager_ios_backend.cc ('k') | net/proxy/proxy_script_fetcher_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698