ios/web/webui/url_data_manager_ios_backend.cc - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/webui/url_data_manager_ios_backend.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing un-modified file Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/webui/url_data_manager_ios_backend.cc

diff --git a/ios/web/webui/url_data_manager_ios_backend.cc b/ios/web/webui/url_data_manager_ios_backend.cc

index 8d1a464074ba787185db8d78371f4416bd152c98..cc3e3e9af8886bfdab7f8a0ee3822425feeab4a3 100644

--- a/ios/web/webui/url_data_manager_ios_backend.cc

+++ b/ios/web/webui/url_data_manager_ios_backend.cc

@@ -415,12 +415,11 @@ URLDataManagerIOSBackend::~URLDataManagerIOSBackend() {

}

// static

-net::URLRequestJobFactory::ProtocolHandler*

-URLDataManagerIOSBackend::CreateProtocolHandler(

- BrowserState* browser_state) {

+scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>

+URLDataManagerIOSBackend::CreateProtocolHandler(BrowserState* browser_state) {

DCHECK(browser_state);

- return new ChromeProtocolHandler(browser_state,

- browser_state->IsOffTheRecord());

+ return make_scoped_ptr(new ChromeProtocolHandler(

+ browser_state, browser_state->IsOffTheRecord()));

}

void URLDataManagerIOSBackend::AddDataSource(URLDataSourceIOSImpl* source) {

« no previous file with comments | « ios/web/webui/url_data_manager_ios_backend.h ('k') | mojo/services/network/url_loader_impl_apptest.cc » ('j') | no next file with comments »