Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: content/browser/loader/resource_loader_unittest.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing un-modified file Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_loader_unittest.cc
diff --git a/content/browser/loader/resource_loader_unittest.cc b/content/browser/loader/resource_loader_unittest.cc
index 0131f2f7448ee5712b99d60bfc2806ef11ad661e..fad86d5b8a3871a6e648c5d9239eed40bdecf815 100644
--- a/content/browser/loader/resource_loader_unittest.cc
+++ b/content/browser/loader/resource_loader_unittest.cc
@@ -8,6 +8,7 @@
#include "base/files/file_util.h"
#include "base/location.h"
#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
#include "base/thread_task_runner_handle.h"
@@ -527,7 +528,8 @@ class ResourceLoaderTest : public testing::Test,
}
}
- virtual net::URLRequestJobFactory::ProtocolHandler* CreateProtocolHandler() {
+ virtual scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+ CreateProtocolHandler() {
return net::URLRequestTestJob::CreateProtocolHandler();
}
@@ -615,8 +617,9 @@ class ResourceLoaderTest : public testing::Test,
class ClientCertResourceLoaderTest : public ResourceLoaderTest {
protected:
- net::URLRequestJobFactory::ProtocolHandler* CreateProtocolHandler() override {
- return new MockClientCertJobProtocolHandler;
+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler> CreateProtocolHandler()
+ override {
+ return make_scoped_ptr(new MockClientCertJobProtocolHandler);
}
};

Powered by Google App Engine
This is Rietveld 408576698