content/browser/loader/navigation_url_loader_unittest.cc - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_url_loader_unittest.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing un-modified file Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/fileapi/blob_url_request_job_unittest.cc ('k') | content/browser/loader/resource_loader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/navigation_url_loader_unittest.cc

diff --git a/content/browser/loader/navigation_url_loader_unittest.cc b/content/browser/loader/navigation_url_loader_unittest.cc

index df5e9d6aeacc7b935c4d3c6eba5771e2c6257fd7..1cefb9b3ffabc4c1a058d3d72ad5f65118ab1065 100644

--- a/content/browser/loader/navigation_url_loader_unittest.cc

+++ b/content/browser/loader/navigation_url_loader_unittest.cc

@@ -165,8 +165,9 @@ class NavigationURLLoaderTest : public testing::Test {

job_factory_.SetProtocolHandler(

"test", net::URLRequestTestJob::CreateProtocolHandler());

job_factory_.SetProtocolHandler(

- "blob", new StreamProtocolHandler(

- StreamContext::GetFor(browser_context_.get())->registry()));

+ "blob",

+ make_scoped_ptr(new StreamProtocolHandler(

+ StreamContext::GetFor(browser_context_.get())->registry())));

request_context->set_job_factory(&job_factory_);

// NavigationURLLoader is only used for browser-side navigations.

« no previous file with comments | « content/browser/fileapi/blob_url_request_job_unittest.cc ('k') | content/browser/loader/resource_loader_unittest.cc » ('j') | no next file with comments »