Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: android_webview/browser/net/aw_url_request_context_getter.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing un-modified file Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/net/aw_url_request_context_getter.cc
diff --git a/android_webview/browser/net/aw_url_request_context_getter.cc b/android_webview/browser/net/aw_url_request_context_getter.cc
index 68ba6313de665692a51b853d845064f5e1eccbf2..7a151fd9f57d89864a3feb9f949285d36550752b 100644
--- a/android_webview/browser/net/aw_url_request_context_getter.cc
+++ b/android_webview/browser/net/aw_url_request_context_getter.cc
@@ -116,29 +116,31 @@ scoped_ptr<net::URLRequestJobFactory> CreateJobFactory(
// AwContentBrowserClient::IsHandledURL.
bool set_protocol = aw_job_factory->SetProtocolHandler(
url::kFileScheme,
- new net::FileProtocolHandler(
- content::BrowserThread::GetBlockingPool()->
- GetTaskRunnerWithShutdownBehavior(
- base::SequencedWorkerPool::SKIP_ON_SHUTDOWN)));
+ make_scoped_ptr(new net::FileProtocolHandler(
+ content::BrowserThread::GetBlockingPool()
+ ->GetTaskRunnerWithShutdownBehavior(
+ base::SequencedWorkerPool::SKIP_ON_SHUTDOWN))));
DCHECK(set_protocol);
set_protocol = aw_job_factory->SetProtocolHandler(
- url::kDataScheme, new net::DataProtocolHandler());
+ url::kDataScheme, make_scoped_ptr(new net::DataProtocolHandler()));
DCHECK(set_protocol);
set_protocol = aw_job_factory->SetProtocolHandler(
url::kBlobScheme,
- (*protocol_handlers)[url::kBlobScheme].release());
+ make_scoped_ptr((*protocol_handlers)[url::kBlobScheme].release()));
DCHECK(set_protocol);
set_protocol = aw_job_factory->SetProtocolHandler(
url::kFileSystemScheme,
- (*protocol_handlers)[url::kFileSystemScheme].release());
+ make_scoped_ptr((*protocol_handlers)[url::kFileSystemScheme].release()));
DCHECK(set_protocol);
set_protocol = aw_job_factory->SetProtocolHandler(
content::kChromeUIScheme,
- (*protocol_handlers)[content::kChromeUIScheme].release());
+ make_scoped_ptr(
+ (*protocol_handlers)[content::kChromeUIScheme].release()));
DCHECK(set_protocol);
set_protocol = aw_job_factory->SetProtocolHandler(
content::kChromeDevToolsScheme,
- (*protocol_handlers)[content::kChromeDevToolsScheme].release());
+ make_scoped_ptr(
+ (*protocol_handlers)[content::kChromeDevToolsScheme].release()));
DCHECK(set_protocol);
protocol_handlers->clear();

Powered by Google App Engine
This is Rietveld 408576698