android_webview/browser/net/aw_url_request_job_factory.h - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/net/aw_url_request_job_factory.h

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing un-modified file Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/net/aw_url_request_context_getter.cc ('k') | android_webview/browser/net/aw_url_request_job_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/net/aw_url_request_job_factory.h

diff --git a/android_webview/browser/net/aw_url_request_job_factory.h b/android_webview/browser/net/aw_url_request_job_factory.h

index 458c1b023eac387ddae490078388eb7358bf5f60..1e7f8b23bb24357c6468f3507caa91d303a09af1 100644

--- a/android_webview/browser/net/aw_url_request_job_factory.h

+++ b/android_webview/browser/net/aw_url_request_job_factory.h

@@ -26,7 +26,7 @@ class AwURLRequestJobFactory : public net::URLRequestJobFactory {

~AwURLRequestJobFactory() override;

bool SetProtocolHandler(const std::string& scheme,

- ProtocolHandler* protocol_handler);

+ scoped_ptr<ProtocolHandler> protocol_handler);

// net::URLRequestJobFactory implementation.

net::URLRequestJob* MaybeCreateJobWithProtocolHandler(