Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1295443002: add asserts on Sk4px::Map functions that our arrays are non-null. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add asserts on Sk4px::Map functions that our arrays are non-null. There's a crasher (null dereference it looks like) in Clank with an impossible stack, but with blit mask on top (apparently sk_free() calls blit mask...). Can't hurt to check that all these Sk4px-using methods are iterating over non-null arrays. (This is that bug I mentioned that got me thinking about blit mask in the first place.) BUG=520354 Committed: https://skia.googlesource.com/skia/+/15f4951e84a0aef2ed31b2e66129579feaa18850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/core/Sk4px.h View 4 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 4 months ago (2015-08-13 14:20:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295443002/1
5 years, 4 months ago (2015-08-13 14:31:55 UTC) #4
reed1
lgtm
5 years, 4 months ago (2015-08-13 14:35:38 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-13 14:39:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295443002/1
5 years, 4 months ago (2015-08-13 14:51:05 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 14:51:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/15f4951e84a0aef2ed31b2e66129579feaa18850

Powered by Google App Engine
This is Rietveld 408576698