Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1295373003: Remove sequential_promise_test helper, just use promise_test (Closed)

Created:
5 years, 4 months ago by jsbell
Modified:
5 years, 4 months ago
Reviewers:
ortuno
CC:
blink-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove sequential_promise_test helper, just use promise_test The upstream implementation of promise_test() in web-platform-test has changed to run the tests sequentially, removing the need for the sequential_promise_test() helper. Tests now just use promise_test() directly. BUG=451338 R=ortuno@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200765

Patch Set 1 #

Patch Set 2 : Remove from non-http tests as well #

Patch Set 3 : remove testharness-helpers.js inclusion from bluetooth tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -149 lines) Patch
M LayoutTests/bluetooth/connectGATT.html View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M LayoutTests/bluetooth/getCharacteristic.html View 1 2 7 chunks +6 lines, -7 lines 0 comments Download
M LayoutTests/bluetooth/getPrimaryService.html View 1 2 6 chunks +5 lines, -6 lines 0 comments Download
M LayoutTests/bluetooth/idl-BluetoothDevice.html View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M LayoutTests/bluetooth/iframeRequestDevice.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/bluetooth/readValue.html View 1 2 6 chunks +5 lines, -6 lines 0 comments Download
M LayoutTests/bluetooth/requestDevice.html View 1 10 chunks +15 lines, -15 lines 0 comments Download
M LayoutTests/bluetooth/writeValue.html View 1 2 7 chunks +6 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/fetch/chromium/error-messages.html View 4 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/fetch/resources/thorough-util.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/body-mixin.js View 10 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/fetch.js View 12 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/filtered-response.js View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/stream-reader.js View 9 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/http/tests/navigatorconnect/resources/connect-event-worker.js View 8 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/resources/testharness-helpers.js View 1 chunk +0 lines, -20 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/getregistrations.html View 5 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/resources/testharness-helpers.js View 1 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jsbell
ortuno@ - please take a look?
5 years, 4 months ago (2015-08-18 20:43:44 UTC) #1
ortuno
Thanks! bluetooth LGTM I would also take a look at this CL that unified the ...
5 years, 4 months ago (2015-08-18 21:14:44 UTC) #2
jsbell
On 2015/08/18 21:14:44, ortuno wrote: > I would also take a look at this CL ...
5 years, 4 months ago (2015-08-18 22:03:45 UTC) #3
ortuno
On 2015/08/18 at 22:03:45, jsbell wrote: > On 2015/08/18 21:14:44, ortuno wrote: > > I ...
5 years, 4 months ago (2015-08-18 22:10:07 UTC) #4
jsbell
Okay - for now I'm just removing uses of testharness-helpers.js from bluetooth, as fetch, serviceworker ...
5 years, 4 months ago (2015-08-18 22:21:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295373003/40001
5 years, 4 months ago (2015-08-18 22:21:53 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 23:16:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200765

Powered by Google App Engine
This is Rietveld 408576698