Unify multiple sequential_promise_test definitions.

Unify multiple sequential_promise_test definitions.

Still leaves two copies since testharness-helpers.js exists in two places, but
other than that this reduces code duplication and makes it easier for other
tests to use this method.

BUG=None

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197842

[Marijn Kruisselbrink, 2015-06-25 01:09:00]

mek@chromium.org changed reviewers:
+ hiroshige@chromium.org, ortuno@chromium.org

[ortuno, 2015-06-25 01:36:24]

ortuno@chromium.org changed reviewers:
+ dpranke@chromium.org

[ortuno, 2015-06-25 01:36:25]

This is what I proposed at the beginning but I was told no by @dpranke:

https://codereview.chromium.org/1062393002#msg13

[Dirk Pranke, 2015-06-25 01:47:30]

dpranke@chromium.org changed reviewers:
+ jsbell@chromium.org

[Dirk Pranke, 2015-06-25 01:47:39]

On 2015/06/25 01:36:25, ortuno wrote:
> This is what I proposed at the beginning but I was told no by @dpranke:
> 
> https://codereview.chromium.org/1062393002#msg13

There has been progress since then. Please coordinate w/ jsbell@ to get the
harnesses in sync.

[hiroshige, 2015-06-25 10:46:19]

https://codereview.chromium.org/1211623005/diff/20001/LayoutTests/http/tests/...
File LayoutTests/http/tests/fetch/window/fetch.html (right):

https://codereview.chromium.org/1211623005/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/fetch/window/fetch.html:4: <script src =
"/resources/testharness-helpers.js"></script>
http/tests/fetch/window/*.html is generated from
http/tests/fetch/script-tests/TEMPLATE-*.html files.
So please modify TEMPLATE-*.html files and run generate.py (see README).

[jsbell, 2015-06-25 16:16:55]

conceptually l*g*t*m:

* unifying helpers like sequential_promise_test into testharness-helpers instead
of duplicating across the codebase is the right thing to do, and this simplifies
the existing tests

* if this concept is NOT adopted into wpt (i.e. ortuno's PR is rejected) then
the onus will be on the folks upstreaming the tests (bluetooth, fetch) to
include a copy when upstreaming. That's not a huge burden. It's looking like the
PR will be accepted, too.

But let's get the fetch tests re-generated as hiroshige points out.

[Marijn Kruisselbrink, 2015-06-25 16:51:24]

Updated to also remove yet another duplicate of sequential_promise_test that I
landed yesterday, and to update the required TEMPLATE-* files for the fetch
tests.

https://codereview.chromium.org/1211623005/diff/20001/LayoutTests/http/tests/...
File LayoutTests/http/tests/fetch/window/fetch.html (right):

https://codereview.chromium.org/1211623005/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/fetch/window/fetch.html:4: <script src =
"/resources/testharness-helpers.js"></script>
On 2015/06/25 at 10:46:19, hiroshige wrote:
> http/tests/fetch/window/*.html is generated from
http/tests/fetch/script-tests/TEMPLATE-*.html files.
> So please modify TEMPLATE-*.html files and run generate.py (see README).

Ah yes, sorry, should have read the README. Done that way now.

[jsbell, 2015-06-25 17:15:58]

lgtm

[ortuno, 2015-06-25 17:30:21]

bluetooth LGTM

[Marijn Kruisselbrink, 2015-06-25 17:59:09]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2015-06-25 17:59:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1211623005/40001

[commit-bot: I haz the power, 2015-06-25 18:25:45]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197842