use_udev is more accurate than is_linux for udev gn deps

use_udev is more accurate than is_linux for udev gn deps

TBR=keybuk

Committed: https://crrev.com/233247d24ad193cecc6b8fd79b7f6d9d5e265edd
Cr-Commit-Position: refs/heads/master@{#344046}

[Mostyn Bramley-Moore, 2015-08-18 19:29:36]

mostynb@opera.com changed reviewers:
+ keybuk@chromium.org, tfarina@chromium.org

[Mostyn Bramley-Moore, 2015-08-18 19:30:17]

@keybuk: please take a look at this tiny fixup to Thiago's old CL:
https://codereview.chromium.org/434243003

[tfarina, 2015-08-18 19:39:36]

Matches GYP.
https://chromium.googlesource.com/chromium/src/+/master/device/hid/hid.gyp#60

LGTM, thanks.

[Mostyn Bramley-Moore, 2015-08-18 19:57:10]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2015-08-18 19:57:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1295353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1295353002/1

[Mostyn Bramley-Moore, 2015-08-18 19:59:01]

The CQ bit was unchecked by mostynb@opera.com

[Mostyn Bramley-Moore, 2015-08-18 20:01:54]

On 2015/08/18 19:39:36, tfarina wrote:
> Matches GYP.
> https://chromium.googlesource.com/chromium/src/+/master/device/hid/hid.gyp#60
> 
> LGTM, thanks.

I spotted a couple more instances of the same issue in device/ ...

[tfarina, 2015-08-18 20:09:20]

Still LGTM.

Thanks for finding all the entries.

https://codereview.chromium.org/1295353002/diff/20001/device/serial/BUILD.gn
File device/serial/BUILD.gn (right):

https://codereview.chromium.org/1295353002/diff/20001/device/serial/BUILD.gn#...
device/serial/BUILD.gn:52: if (use_udev) {
OK.

https://chromium.googlesource.com/chromium/src/+/master/device/serial/serial....

https://codereview.chromium.org/1295353002/diff/20001/device/usb/BUILD.gn
File device/usb/BUILD.gn (right):

https://codereview.chromium.org/1295353002/diff/20001/device/usb/BUILD.gn#new...
device/usb/BUILD.gn:48: if (use_udev) {
OK.

https://chromium.googlesource.com/chromium/src/+/master/device/usb/usb.gyp#70

[Mostyn Bramley-Moore, 2015-08-18 20:11:12]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2015-08-18 20:12:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1295353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1295353002/20001

[commit-bot: I haz the power, 2015-08-18 20:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 20:17:04]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[tfarina, 2015-08-18 20:23:04]

Looks like it is missing import("//build/config/features.gni")

[Mostyn Bramley-Moore, 2015-08-18 20:27:28]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-18 20:28:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1295353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1295353002/40001

[commit-bot: I haz the power, 2015-08-18 21:32:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 21:33:00]

Dry run: This issue passed the CQ dry run.

[Mostyn Bramley-Moore, 2015-08-18 21:37:01]

The CQ bit was checked by mostynb@opera.com

[Mostyn Bramley-Moore, 2015-08-18 21:37:02]

The patchset sent to the CQ was uploaded after l-g-t-m from tfarina@chromium.org
Link to the patchset: https://codereview.chromium.org/1295353002/#ps40001
(title: "import features.gni")

[commit-bot: I haz the power, 2015-08-18 21:37:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1295353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1295353002/40001

[commit-bot: I haz the power, 2015-08-18 21:47:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 21:47:53]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mostyn Bramley-Moore, 2015-08-18 22:01:41]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2015-08-18 22:02:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1295353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1295353002/40001

[commit-bot: I haz the power, 2015-08-18 22:08:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-18 22:08:43]

Patchset 3 (id:??) landed as
https://crrev.com/233247d24ad193cecc6b8fd79b7f6d9d5e265edd
Cr-Commit-Position: refs/heads/master@{#344046}