extensions: Add GN version of extensions_shell_and_test_pak and unittests target.

extensions: Add GN version of extensions_shell_and_test_pak and unittests target.

BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn extensions:unittsts
R=brettw@chromium.org,kalman@chromium.org
TBR=keybuk@chromium.org # for device

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287957

[tfarina, 2014-08-04 04:14:14]

Brett, Benjamin main reviewers.

Note, this was the further I could go. Two remaining errors below. Man, the
content setup, both GYP and GN are non-trivial (it could get some
simplification)!!

obj/components/usb_service/usb_service.usb_error.o:../../components/usb_service/usb_error.cc:function
usb_service::ConvertErrorToString(int): error: undefined reference to
'libusb_strerror'
obj/content/test/libtest_support.a(test_support.test_launcher.o):../../content/public/test/test_launcher.cc:function
content::LaunchTests(content::TestLauncherDelegate*, int, int, char**): error:
undefined reference to 'content::ContentMain(content::ContentMainParams const&)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Yoyo, James, fyi.

James, looks like you forgot to add extensions_test.cc to GN when you added to
gyp file.

Keybuk -> device/, mostly fyi. Also note that the GYP file is missing the
'dependencies' list!

[tfarina, 2014-08-04 04:18:25]

Also, note that I didn't look further because it is late here, 1:15: AM and
classes are back, so tomorrow is a busy day for me :(

[brettw, 2014-08-04 04:28:53]

If you want, you can check in the test commented out with a TODO(GYP) (since you
were only having linker errors) and come back to it.

https://codereview.chromium.org/434243003/diff/1/device/hid/BUILD.gn
File device/hid/BUILD.gn (right):

https://codereview.chromium.org/434243003/diff/1/device/hid/BUILD.gn#newcode54
device/hid/BUILD.gn:54: "device_monitor_linux.cc",
You shouldn't need these as *_linux should be removed automatically for
non-Linux platforms.

https://codereview.chromium.org/434243003/diff/1/extensions/BUILD.gn
File extensions/BUILD.gn (right):

https://codereview.chromium.org/434243003/diff/1/extensions/BUILD.gn#newcode178
extensions/BUILD.gn:178: if (is_win) { # and win_use_allocator_shim==1
You can delete this comment. The base/allocator target only does something when
the allocator shim is turned on, otherwise it does nothing (which saves a lot of
conditionals like this).

https://codereview.chromium.org/434243003/diff/1/extensions/browser/BUILD.gn
File extensions/browser/BUILD.gn (right):

https://codereview.chromium.org/434243003/diff/1/extensions/browser/BUILD.gn#...
extensions/browser/BUILD.gn:6: import("//build/config/crypto.gni")
Nit: sort

https://codereview.chromium.org/434243003/diff/1/extensions/browser/BUILD.gn#...
extensions/browser/BUILD.gn:264: "//crypto:platform",
Nit: sort

[James Cook, 2014-08-04 16:32:02]

I landed https://codereview.chromium.org/435703002/ this weekend which moved a
bunch of tests from chrome_tests_unit.gypi to extensions.gyp. I didn't update
the BUILD.gn file for those, apologies. Would you like me to move them in
another CL, or would you like to move them as part of this one?

brettw, it seems pretty easy for people like me to forget to move a test file
into the BUILD.gn rules, especially since everything will compile and link
without it. Do you guys have a solution to this for other parts of the project?

Any idea when we could switch the src/extensions module to GN-only?

[brettw, 2014-08-04 16:58:10]

James: just do a separate patch and update those.

I don't have a good solution for the forgotten test files problem. Before we
switch over, we'll probably have to do an audit for missing things like this.

You can't delete the GYP files until everything else is GN-only, sadly. So it
will be a while. Hopefully in about a month it will be possible for people to
use the GN build on Linux as their main development environment.

[tfarina, 2014-08-05 14:13:19]

Brett, ptal.

https://codereview.chromium.org/434243003/diff/1/device/hid/BUILD.gn
File device/hid/BUILD.gn (right):

https://codereview.chromium.org/434243003/diff/1/device/hid/BUILD.gn#newcode54
device/hid/BUILD.gn:54: "device_monitor_linux.cc",
On 2014/08/04 04:28:52, brettw wrote:
> You shouldn't need these as *_linux should be removed automatically for
> non-Linux platforms.

Done.

https://codereview.chromium.org/434243003/diff/1/extensions/BUILD.gn
File extensions/BUILD.gn (right):

https://codereview.chromium.org/434243003/diff/1/extensions/BUILD.gn#newcode178
extensions/BUILD.gn:178: if (is_win) { # and win_use_allocator_shim==1
On 2014/08/04 04:28:52, brettw wrote:
> You can delete this comment. The base/allocator target only does something
when
> the allocator shim is turned on, otherwise it does nothing (which saves a lot
of
> conditionals like this).

Done.

https://codereview.chromium.org/434243003/diff/1/extensions/browser/BUILD.gn
File extensions/browser/BUILD.gn (right):

https://codereview.chromium.org/434243003/diff/1/extensions/browser/BUILD.gn#...
extensions/browser/BUILD.gn:6: import("//build/config/crypto.gni")
On 2014/08/04 04:28:52, brettw wrote:
> Nit: sort

Done.

https://codereview.chromium.org/434243003/diff/1/extensions/browser/BUILD.gn#...
extensions/browser/BUILD.gn:264: "//crypto:platform",
On 2014/08/04 04:28:52, brettw wrote:
> Nit: sort

Done.

[tfarina, 2014-08-05 16:21:22]

I forgot to add the TODO. I will add it tomorrow.

I will also have to rebase to pick up James' change that added extensions_test.*
to BUILD.gn. I just haven't had time this morning.

[tfarina, 2014-08-06 14:25:20]

I have added the TODO and rebase. Should be fine now.

ptal?

[brettw, 2014-08-06 17:34:48]

lgtm

[not at google - send to devlin, 2014-08-06 17:43:30]

lgtm

[tfarina, 2014-08-07 02:26:23]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-08-07 02:31:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/434243003/40001

[commit-bot: I haz the power, 2014-08-07 03:32:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-07 03:35:25]

Change committed as 287957