Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 1295233003: Sync GN tests with GYP build. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, tapted, hguihot+watch_chromium.org, jasonroberts+watch_google.com, tdresser+watch_chromium.org, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, Matt Giuca, tfarina, cc-bugs_chromium.org, jdduke+watch_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@test_fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync GN tests with GYP build. This updates GN's app_list_unittests, base_unittests, cast_unittests, cc_unittests, components_unittests, crypto_unittests, events_unittests, and gl_unittests to match the GYP build (with the exception of some NaCl-specific ones). The printing component is now hooked up to all components, and the printing names were fixed to be GN-style and to be source sets instead of shared libraries. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d649f6b22c90bafe885294fac6f0cf67c48cb425 Cr-Commit-Position: refs/heads/master@{#344024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -11 lines) Patch
M base/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M cc/BUILD.gn View 6 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 3 chunks +14 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/printing/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/renderer/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/printing/test/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M crypto/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (8 generated)
brettw
5 years, 4 months ago (2015-08-17 23:45:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295233003/1
5 years, 4 months ago (2015-08-18 00:02:34 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/75586)
5 years, 4 months ago (2015-08-18 02:41:08 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295233003/1
5 years, 4 months ago (2015-08-18 04:47:46 UTC) #10
jam
lgtm
5 years, 4 months ago (2015-08-18 05:09:31 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/75611)
5 years, 4 months ago (2015-08-18 06:40:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295233003/1
5 years, 4 months ago (2015-08-18 20:15:03 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 20:58:58 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 20:59:38 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d649f6b22c90bafe885294fac6f0cf67c48cb425
Cr-Commit-Position: refs/heads/master@{#344024}

Powered by Google App Engine
This is Rietveld 408576698