Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1289423004: Sync GN unit tests with GYP, add checking script. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync GN unit tests with GYP, add checking script. Some of these JavaScript gtest tests were missing from the GN build because they needed to go into a special target. The included script will find and print out lists of test differences. Committed: https://crrev.com/b2f72715a4899c690f92529f91fa3a9adf9db5ff Cr-Commit-Position: refs/heads/master@{#343820}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -1 line) Patch
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A tools/gn/bin/compare_test_lists.py View 1 2 1 chunk +101 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (7 generated)
brettw
5 years, 4 months ago (2015-08-17 20:53:30 UTC) #2
jam
lgtm maybe also print out GYP_DEFINES and the args.gn file in the gn directory so ...
5 years, 4 months ago (2015-08-17 20:56:21 UTC) #3
brettw
New snap up that strips comments in gtest output (it does this for certain enumerated ...
5 years, 4 months ago (2015-08-17 21:07:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289423004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289423004/40001
5 years, 4 months ago (2015-08-17 21:09:46 UTC) #7
jam
lgtm
5 years, 4 months ago (2015-08-17 21:11:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289423004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289423004/40001
5 years, 4 months ago (2015-08-17 23:43:05 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99336)
5 years, 4 months ago (2015-08-18 01:13:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289423004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289423004/40001
5 years, 4 months ago (2015-08-18 01:24:33 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-18 05:21:40 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/b2f72715a4899c690f92529f91fa3a9adf9db5ff Cr-Commit-Position: refs/heads/master@{#343820}
5 years, 4 months ago (2015-08-18 05:22:47 UTC) #17
msramek
5 years, 4 months ago (2015-08-18 11:29:14 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1284423005/ by msramek@chromium.org.

The reason for reverting is: Breakage of tests on Linux GN. See crbug.com/521944
for more details..

Powered by Google App Engine
This is Rietveld 408576698