Make cvox2 output feedback more robust when focusing a text field.

chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
index 7e7f4806bff9443e9fbe559fbf7a0186b70274d4..a25c02fcf72490e8c24cdcdff6944f0b2e5a269d 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
@@ -23,6 +23,7 @@ BackgroundTest.prototype = {
   setUp: function() {
     this.mockTts = new MockTts();
     cvox.ChromeVox.tts = this.mockTts;
+    global.backgroundObj.forceChromeVoxNextActive();

[Peter Lundblad, 2015/08/20 08:30:06]

ChromeVoxE2ETest.runWithTab already adds chromevox_next_test to the url which
should cause next to be enabled. If that logic is not working, we should
probably clean it
up whn adding this line, making sure that it was the cause of the flakiness.

[David Tseng, 2015/08/20 17:52:47]

That logic depends on a load complete event to be observed, so there's a
possibility that classic gets injected first. With force next (different from
just the #chromevox_next_test), classic doesn't get started at all.

   },
 
   /**
@@ -242,3 +243,30 @@ TEST_F('BackgroundTest', 'AriaLabel', function() {
       rootNode.focus();
     }.bind(this));
 });
+
+TEST_F('BackgroundTest', 'FocusInputElement', function() {
+  this.runWithLoadedTree(
+    function() {/*!
+      <input id="name" value="Lancelot">
+      <input id="quest" value="Grail">
+      <input id="color" value="Blue">
+    */},
+    function(rootNode) {
+      cvox.ChromeVox.tts.expectSpeech('Grail');
+      cvox.ChromeVox.tts.expectSpeech('Edit text');
+
+      cvox.ChromeVox.tts.expectSpeech('Blue');
+      cvox.ChromeVox.tts.expectSpeech('Edit text');
+
+      var quest = rootNode.find({ attributes: { value: 'Grail' } });
+      quest.focus();
+
+      window.setTimeout(this.newCallback(function() {
+        var color = rootNode.find({ attributes: { value: 'Blue' } });
+        color.focus();
+
+        cvox.ChromeVox.tts.finishExpectations(this.newCallback());
+      }), 100);

[David Tseng, 2015/08/19 17:19:25]

Can you do this without a timeout (e.g. by adding a focus event handler)?

[Peter Lundblad, 2015/08/20 08:30:06]

I bet this will flake on some memmory bot. We shouldn't use timeouts for this,
but instead arrange for this to be done in a callback after the previous
expectation
is met.

[David Tseng, 2015/08/20 17:52:47]

See my suggestion above (about focus event handler).

+
+    }.bind(this));

[Peter Lundblad, 2015/08/20 08:30:06]

Superflous bind.

+});