Make cvox2 output feedback more robust when focusing a text field.

chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Include test fixture.
 GEN_INCLUDE(['../../testing/chromevox_next_e2e_test_base.js']);
 
 GEN_INCLUDE(['../../testing/mock_tts.js']);
 
 /**
  * Test fixture for Background.
  * @constructor
  * @extends {ChromeVoxNextE2ETest}
  */
 function BackgroundTest() {
   ChromeVoxNextE2ETest.call(this);
 }
 
 BackgroundTest.prototype = {
   __proto__: ChromeVoxNextE2ETest.prototype,
 
   /** @override */
   setUp: function() {
     this.mockTts = new MockTts();
     cvox.ChromeVox.tts = this.mockTts;
+    global.backgroundObj.forceChromeVoxNextActive();

[Peter Lundblad, 2015/08/20 08:30:06]

ChromeVoxE2ETest.runWithTab already adds chromevox_next_test to the url which
should cause next to be enabled. If that logic is not working, we should
probably clean it
up whn adding this line, making sure that it was the cause of the flakiness.

[David Tseng, 2015/08/20 17:52:47]

That logic depends on a load complete event to be observed, so there's a
possibility that classic gets injected first. With force next (different from
just the #chromevox_next_test), classic doesn't get started at all.

   },
 
   /**
    * Create a function which perform the command |cmd|.
    * @param {string} cmd
    * @return {function() : void}
    */
   doCmd: function(cmd) {
     return function() {
       global.backgroundObj.onGotCommand(cmd);
@@ skipping 199 matching lines @@
 // TODO(plundblad): This test finishes prematurely and breaks if that gets
 // fixed.
 TEST_F('BackgroundTest', 'AriaLabel', function() {
   this.runWithLoadedTree('<a aria-label="foo" href="a">a</a>',
     function(rootNode) {
       cvox.ChromeVox.tts.expectSpeech('foo link', testDone);
 
       rootNode.focus();
     }.bind(this));
 });
+
+TEST_F('BackgroundTest', 'FocusInputElement', function() {
+  this.runWithLoadedTree(
+    function() {/*!
+      <input id="name" value="Lancelot">
+      <input id="quest" value="Grail">
+      <input id="color" value="Blue">
+    */},
+    function(rootNode) {
+      cvox.ChromeVox.tts.expectSpeech('Grail');
+      cvox.ChromeVox.tts.expectSpeech('Edit text');
+
+      cvox.ChromeVox.tts.expectSpeech('Blue');
+      cvox.ChromeVox.tts.expectSpeech('Edit text');
+
+      var quest = rootNode.find({ attributes: { value: 'Grail' } });
+      quest.focus();
+
+      window.setTimeout(this.newCallback(function() {
+        var color = rootNode.find({ attributes: { value: 'Blue' } });
+        color.focus();
+
+        cvox.ChromeVox.tts.finishExpectations(this.newCallback());
+      }), 100);

[David Tseng, 2015/08/19 17:19:25]

Can you do this without a timeout (e.g. by adding a focus event handler)?

[Peter Lundblad, 2015/08/20 08:30:06]

I bet this will flake on some memmory bot. We shouldn't use timeouts for this,
but instead arrange for this to be done in a callback after the previous
expectation
is met.

[David Tseng, 2015/08/20 17:52:47]

See my suggestion above (about focus event handler).

+
+    }.bind(this));

[Peter Lundblad, 2015/08/20 08:30:06]

Superflous bind.

+});