Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1295063002: Revert "Remove old serializer" It caused a regression, crbug.com/510422 (Closed)

Created:
5 years, 4 months ago by tkent
Modified:
5 years, 4 months ago
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Remove old serializer" It caused a regression, crbug.com/510422 > Remove old serializer > > Remove old serializer (WebPageSerializerImpl) and its tests > (WebPageSerializerTest and resources) and use PageSerializer for all > serialization tasks in WebPageSerializer. > > -- > > This review is part of set aiming to merge the two existing page > serializers, WebPageSerializerImpl and PageSerializer into the latter > one. > > In addition to this it moves all the old tests from > WebPageNewSerializerTest and WebPageSerializerTest to the newer > PageSerializerTest structure and splits out a test for MHTML into the > MHTMLTest file. > > Note: This is a rebase and split of > https://codereview.chromium.org/68613003 from Opera which was reverted > due to failing tests. In addition to the rebase some smaller fixes was > done to accommodate to changes in the code from when it was first > landed. > > BUG=328354 > R=hajimehoshi@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198151 > > Review URL: https://codereview.chromium.org/1177733003 BUG=328354, 510422 TBR=hajimehoshi@chromium.org,gustav.tiger@sonymobile.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1152 lines, -22 lines) Patch
M Source/web/WebPageSerializer.cpp View 5 chunks +141 lines, -20 lines 0 comments Download
A Source/web/WebPageSerializerImpl.h View 1 chunk +193 lines, -0 lines 0 comments Download
A Source/web/WebPageSerializerImpl.cpp View 1 chunk +520 lines, -0 lines 0 comments Download
A Source/web/tests/WebPageSerializerTest.cpp View 1 chunk +180 lines, -0 lines 0 comments Download
A + Source/web/tests/data/pageserialization/awesome.png View Binary file 0 comments Download
A Source/web/tests/data/pageserialization/beautifull.css View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/web/tests/data/pageserialization/embed_iframe.html View 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/web/tests/data/pageserialization/object_iframe.html View 1 chunk +2 lines, -0 lines 0 comments Download
A Source/web/tests/data/pageserialization/simple_iframe.html View 1 chunk +14 lines, -0 lines 0 comments Download
A Source/web/tests/data/pageserialization/simple_page.html View 1 chunk +50 lines, -0 lines 0 comments Download
A Source/web/tests/data/pageserialization/top_frame.html View 1 chunk +28 lines, -0 lines 0 comments Download
M Source/web/web.gypi View 3 chunks +10 lines, -0 lines 0 comments Download
M public/web/WebPageSerializer.h View 1 chunk +8 lines, -0 lines 0 comments Download
M public/web/WebPageSerializerClient.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
tkent
5 years, 4 months ago (2015-08-17 02:10:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295063002/1
5 years, 4 months ago (2015-08-17 02:10:51 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/42566)
5 years, 4 months ago (2015-08-17 02:49:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295063002/1
5 years, 4 months ago (2015-08-17 03:06:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/40222)
5 years, 4 months ago (2015-08-17 03:11:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295063002/1
5 years, 4 months ago (2015-08-17 03:30:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/99632)
5 years, 4 months ago (2015-08-17 04:12:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295063002/1
5 years, 4 months ago (2015-08-17 04:13:48 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 05:06:52 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200628

Powered by Google App Engine
This is Rietveld 408576698