Merge page serializers [12/12]

Remove old serializer

Remove old serializer (WebPageSerializerImpl) and its tests
(WebPageSerializerTest and resources) and use PageSerializer for all
serialization tasks in WebPageSerializer.

--

This review is part of set aiming to merge the two existing page
serializers, WebPageSerializerImpl and PageSerializer into the latter
one.

In addition to this it moves all the old tests from
WebPageNewSerializerTest and WebPageSerializerTest to the newer
PageSerializerTest structure and splits out a test for MHTML into the
MHTMLTest file.

Note: This is a rebase and split of
https://codereview.chromium.org/68613003 from Opera which was reverted
due to failing tests. In addition to the rebase some smaller fixes was
done to accommodate to changes in the code from when it was first
landed.

BUG=328354
R=hajimehoshi@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198151

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198503

[Tiger (Sony Mobile), 2015-06-10 14:06:55]

PTAL

[hajimehoshi, 2015-06-12 13:56:45]

hajimehoshi@chromium.org changed reviewers:
+ yosin@chromium.org

[hajimehoshi, 2015-06-12 13:58:05]

+yosin (I'm ooo on Monday)

[yosin_UTC9, 2015-06-15 09:38:38]

https://codereview.chromium.org/1177733003/diff/1/Source/web/WebPageSerialize...
File Source/web/WebPageSerializer.cpp (right):

https://codereview.chromium.org/1177733003/diff/1/Source/web/WebPageSerialize...
Source/web/WebPageSerializer.cpp:133: for (size_t i = 0; i < links.size(); i++)
{
We can use range-for on |WebVector|.

https://codereview.chromium.org/1177733003/diff/1/Source/web/WebPageSerialize...
Source/web/WebPageSerializer.cpp:143: for
(Vector<SerializedResource>::const_iterator iter = resources.begin(); iter !=
resources.end(); ++iter) {
We can use range-for on |Vector|.

[Tiger (Sony Mobile), 2015-06-15 12:00:25]

https://codereview.chromium.org/1177733003/diff/1/Source/web/WebPageSerialize...
File Source/web/WebPageSerializer.cpp (right):

https://codereview.chromium.org/1177733003/diff/1/Source/web/WebPageSerialize...
Source/web/WebPageSerializer.cpp:133: for (size_t i = 0; i < links.size(); i++)
{
On 2015/06/15 09:38:38, Yosi_UTC9 wrote:
> We can use range-for on |WebVector|.

The index is used both for links and localPaths to create a map so it doesn't
really fit to use a ranged for loop here.

https://codereview.chromium.org/1177733003/diff/1/Source/web/WebPageSerialize...
Source/web/WebPageSerializer.cpp:143: for
(Vector<SerializedResource>::const_iterator iter = resources.begin(); iter !=
resources.end(); ++iter) {
On 2015/06/15 09:38:38, Yosi_UTC9 wrote:
> We can use range-for on |Vector|.

Done.

[yosin_UTC9, 2015-06-16 01:06:41]

lgtm

+tkent@ as web/ OWNERS

[hajimehoshi, 2015-06-16 04:47:09]

lgtm

[philipj_slow, 2015-07-01 12:40:40]

philipj@opera.com changed reviewers:
+ philipj@opera.com

[philipj_slow, 2015-07-01 12:40:41]

lgtm

Nothing like a big red diff to end a series of CLs.

[Tiger (Sony Mobile), 2015-07-01 15:07:15]

The CQ bit was checked by gustav.tiger@sonymobile.com

[Tiger (Sony Mobile), 2015-07-01 15:07:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
hajimehoshi@chromium.org, yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1177733003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2015-07-01 15:07:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1177733003/40001

[commit-bot: I haz the power, 2015-07-01 16:11:55]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198151

[Nate Chapin, 2015-07-01 19:21:31]

On 2015/07/01 16:11:55, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=198151

This was reverted due to browser_tests failures:
https://codereview.chromium.org/1177733003

[Tiger (Sony Mobile), 2015-07-08 14:45:20]

The CQ bit was checked by gustav.tiger@sonymobile.com

[commit-bot: I haz the power, 2015-07-08 14:45:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1177733003/40001

[commit-bot: I haz the power, 2015-07-08 16:00:46]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198503

[tkent, 2015-08-17 02:13:09]

On 2015/07/08 16:00:46, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=198503

I'm reverting this because of crbug.com/510422.