Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1294913005: [d8] Fix flakiness when calling quit() with isolates (Closed)

Created:
5 years, 4 months ago by binji
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8] Fix flakiness when calling quit() with isolates Don't use exit(), use Shell::Exit() (which calls _exit() instead). This won't run C++ static destructors, atexit() functions, etc., which can occasionally cause flaky failures. BUG=v8:4279 R=machenbach@chromium.org LOG=n Committed: https://crrev.com/41fa3573d53d0d1b45a3c08ef1cb53535dec4bf2 Cr-Commit-Position: refs/heads/master@{#30229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
binji
I tested this with: tools/run-tests.py --buildbot --outdir out --arch x64 --mode Debug --isolates mjsunit/regress/regress-4279 --stress-only ...
5 years, 4 months ago (2015-08-17 22:18:56 UTC) #1
Jarin
lgtm
5 years, 4 months ago (2015-08-18 05:03:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294913005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294913005/1
5 years, 4 months ago (2015-08-18 16:46:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 16:47:23 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 16:47:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41fa3573d53d0d1b45a3c08ef1cb53535dec4bf2
Cr-Commit-Position: refs/heads/master@{#30229}

Powered by Google App Engine
This is Rietveld 408576698