src/d8.cc - Issue 1294913005: [d8] Fix flakiness when calling quit() with isolates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.cc

Issue 1294913005: [d8] Fix flakiness when calling quit() with isolates (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/d8.cc

diff --git a/src/d8.cc b/src/d8.cc

index d1eb9592777b3cfe2270df001c36db49885447c5..524051921b0c94af83d3a74dac77482dedbcdbcd 100644

--- a/src/d8.cc

+++ b/src/d8.cc

@@ -814,7 +814,7 @@ void Shell::QuitOnce(v8::FunctionCallbackInfo<v8::Value>* args) {

CleanupWorkers();

#endif // !V8_SHARED

OnExit(args->GetIsolate());

- exit(exit_code);

+ Exit(exit_code);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »